From: Finn Thain <fthain@telegraphics.com.au>
To: linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org
Cc: Stan <userm57@yahoo.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: pata-macio on PowerBook G3: stuck interrupt with MATSHITA CR-174 CD-ROM
Date: Thu, 11 Jul 2019 10:26:27 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1906291014050.119@nippy.intranet> (raw)
In-Reply-To: <alpine.LNX.2.21.1906271717080.68@nippy.intranet>
On Fri, 28 Jun 2019, Finn Thain wrote:
> Hi All,
>
> I've received a bug report concerning the pata-macio driver, when running
> on a PowerBook G3 (Wallstreet).
>
> With CONFIG_PATA_MACIO=n && CONFIG_BLK_DEV_IDE_PMAC=y, everything works.
>
> With CONFIG_PATA_MACIO=y && CONFIG_BLK_DEV_IDE_PMAC=n, the CD-ROM fails.
>
> When the CD-ROM mediabay module is swapped for a DVD-ROM mediabay module,
> everything works (either pata-macio or ide-pmac driver works fine).
>
> I'm not familiar with ATA device drivers or the "Heathrow" chipset and its
> ATA interfaces so any hints as to how to debug this would be appreciated.
>
...
>
> These logs are from v4.20 but the problem is the same in v5.2-rc2.
>
In the linux-ide list archive I found the same bug reported in 2.6.33-rc2,
shortly after the pata-macio driver was merged.
https://lore.kernel.org/linux-ide/19254.17766.674348.933702@pilspetsen.it.uu.se/
That report also involves a Matshita CD-ROM and a Heathrow controller
(beige G3).
In that thread Ben suggested that the cause may be a firmware bug in the
drive. Is there a quirk or other workaround for that kind of bug?
I tried removing the controller reset but there was no improvement...
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 57f2ec71cfc3..b2fd5e20367f 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1096,7 +1096,7 @@ static int pata_macio_common_init(struct pata_macio_priv *priv,
priv->host->ports[0]->private_data = priv;
/* hard-reset the controller */
- pata_macio_reset_hw(priv, 0);
+// pata_macio_reset_hw(priv, 0);
pata_macio_apply_timings(priv->host->ports[0], 0);
/* Enable bus master if necessary */
--
prev parent reply other threads:[~2019-07-11 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 0:13 pata-macio on PowerBook G3: stuck interrupt with MATSHITA CR-174 CD-ROM Finn Thain
2019-07-11 0:26 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1906291014050.119@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=userm57@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).