Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	vireshk@kernel.org, axboe@kernel.dk, vkoul@kernel.org,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_arasam_cf: Use dma_request_chan() instead dma_request_slave_channel()
Date: Mon, 13 Jan 2020 12:31:56 +0100
Message-ID: <b171c3c0-d924-e2e6-0c4d-196c7e6c2325@samsung.com> (raw)
In-Reply-To: <20191217111950.vzuww3ov4ub45ros@vireshk-i7>


On 12/17/19 12:19 PM, Viresh Kumar wrote:
> On 17-12-19, 12:50, Peter Ujfalusi wrote:
>> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
>> eating up the error code.
>>
>> By using dma_request_chan() directly the driver can support deferred
>> probing against DMA.

It doesn't seem to be the case as DMA channel is requested at the start
of the data transfer (which happens after the driver has been successfully
probed).

PS there is a typo in the patch summary (it should "pata_arasan_cf").

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>>  drivers/ata/pata_arasan_cf.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
>> index 135173c8d138..69b555d83f68 100644
>> --- a/drivers/ata/pata_arasan_cf.c
>> +++ b/drivers/ata/pata_arasan_cf.c
>> @@ -526,9 +526,10 @@ static void data_xfer(struct work_struct *work)
>>  
>>  	/* request dma channels */
>>  	/* dma_request_channel may sleep, so calling from process context */
>> -	acdev->dma_chan = dma_request_slave_channel(acdev->host->dev, "data");
>> -	if (!acdev->dma_chan) {
>> +	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
>> +	if (IS_ERR(acdev->dma_chan)) {
>>  		dev_err(acdev->host->dev, "Unable to get dma_chan\n");
>> +		acdev->dma_chan = NULL;
>>  		goto chan_request_fail;
>>  	}
>>  
>> @@ -539,6 +540,7 @@ static void data_xfer(struct work_struct *work)
>>  	}
>>  
>>  	dma_release_channel(acdev->dma_chan);
>> +	acdev->dma_chan = NULL;
>>  
>>  	/* data xferred successfully */
>>  	if (!ret) {
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 10:50 Peter Ujfalusi
2019-12-17 11:19 ` Viresh Kumar
2020-01-13 11:31   ` Bartlomiej Zolnierkiewicz [this message]
2020-01-13 14:33     ` Peter Ujfalusi

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b171c3c0-d924-e2e6-0c4d-196c7e6c2325@samsung.com \
    --to=b.zolnierkie@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=viresh.kumar@linaro.org \
    --cc=vireshk@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org
	public-inbox-index linux-ide

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git