From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2CEC433EF for ; Mon, 20 Sep 2021 16:43:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EF0C60F38 for ; Mon, 20 Sep 2021 16:43:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239659AbhITQoc (ORCPT ); Mon, 20 Sep 2021 12:44:32 -0400 Received: from mxout02.lancloud.ru ([45.84.86.82]:42278 "EHLO mxout02.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238573AbhITQo1 (ORCPT ); Mon, 20 Sep 2021 12:44:27 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 52B8A222A946 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Fabio Estevam CC: Sergey Shtylyov , Jens Axboe , , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Mon, 20 Sep 2021 19:42:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 9/20/21 3:52 PM, Fabio Estevam wrote: [...] >>>> IMHO the current code is correct as-is. >>> >>> Not quite... I don't want to leave a bad example for the future driver authors. What should >>> I change in the patch description for the patch to become acceptable for you? >> >> Please see how the PCI subsystem has converted the handling of >> platform_get_irq(): >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5 >> >> Why does drivers/ata/ need to handle platform_get_irq() differently? >> >> I still don't see the need for changing drivers/ata/pata_imx.c in this aspect. > > Also, please check this commit too: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=a85a6c86c25be2d2a5f9c31491f612ce0edc7869 You think I haven't seen this? :-) WARN() is not enough to make IRQ invalid, isn't it? MBR, Sergey