From: Markus Elfring <Markus.Elfring@web.de>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
Jens Axboe <axboe@kernel.dk>, Hans de Goede <hdegoede@redhat.com>,
linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ata: libahci_platform: Add of_node_put() before loop exit
Date: Thu, 19 Sep 2019 20:17:34 +0200 [thread overview]
Message-ID: <c61069af-29c0-449a-a07f-c89c5a5535fa@web.de> (raw)
In-Reply-To: <20190815060014.2191-1-nishkadg.linux@gmail.com>
> +++ b/drivers/ata/libahci_platform.c
> @@ -497,6 +497,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>
> if (of_property_read_u32(child, "reg", &port)) {
> rc = -EINVAL;
> + of_node_put(child);
> goto err_out;
> }
I suggest to move the added function call to another jump target.
- goto err_out;
+ goto err_put_node;
…
+err_put_node:
of_node_put(child);
err_out:
…
Regards,
Markus
next prev parent reply other threads:[~2019-09-19 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 6:00 [PATCH] ata: libahci_platform: Add of_node_put() before loop exit Nishka Dasgupta
2019-08-15 8:53 ` for_each_child_of_node semantics are broken (was [PATCH] ata: libahci_platform: Add of_node_put() before loop exit) Hans de Goede
2019-08-15 8:55 ` [PATCH] ata: libahci_platform: Add of_node_put() before loop exit Hans de Goede
2019-09-19 18:17 ` Markus Elfring [this message]
2019-09-22 15:07 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c61069af-29c0-449a-a07f-c89c5a5535fa@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).