From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991C6C433F5 for ; Fri, 3 Sep 2021 14:05:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BA7160E93 for ; Fri, 3 Sep 2021 14:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242849AbhICOG4 (ORCPT ); Fri, 3 Sep 2021 10:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233300AbhICOG4 (ORCPT ); Fri, 3 Sep 2021 10:06:56 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57B10C061575 for ; Fri, 3 Sep 2021 07:05:56 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id r6so5293587ilt.13 for ; Fri, 03 Sep 2021 07:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cgwrXJbGZw7LvqCtZ3SUKKuQrirCjvwKHoEkBgKAZaU=; b=sXrYf6ZM3c1JtQU/3qv/sJb1LUKy8mMGlGmQeonO7HS0NJj0acwq/UI25oqmDf58n4 qqRtijFCHOMLwxe7o0aX434rsvKmUvLjOVufuM4CIU65JkY4dnAuVVh/yUuOFA53K7as wrmNbmyXbO48oXrm76jzfnEZTD5R96EUUtddyr5whSb6BCPQErXw2ZiT+9UcHDVqQ3Ym gl/7ldYNQ6tVd3gJ2X7QEyDRT6UoUVKtl7N/qvq4ceQZW+x+bHXnD0ql8A3oUwIK6DWQ MoRMRl2q4s/hwXjdjwk8R7yNN+ok+ntw32Sc2qtIKJSktRPkhB4Ggoa2lK+HxkUEf5PR fgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cgwrXJbGZw7LvqCtZ3SUKKuQrirCjvwKHoEkBgKAZaU=; b=noIcDLdSQR3L57yXBfzrfn3IelIoriY1btGrgVg0hBm9xJLkLesIajI4dH/aO1eeAI pVelTg8ZGXgIRDhqxj/EOmGfFYsPpgS1W2x0KgHj1TU7Uia2w7wPMA7mvuHg6U4unFgs dEpirK9CPfYhbqJNT1oJHqIalx1O2Mc6plMEY1F4t/Ieopiy3M+6ZwSNU+cPwkNgVus0 QAcnQ1EYAI4erDErbs6O35Q7YiihhtAURzc9m81Felqj/Dd9cX7fZX3ZqUenLy/nmqph RyE9f2Y7KXRVUw3ZwceNULiX+ugO8P3nTLlGBOAFsqWw3SjgHOUPXTW5SBqMT3ALduIS 1xWw== X-Gm-Message-State: AOAM5329/f9iTTvGYn7PFxj1VWyGczmsN18KPxVdXs5fSAh+b5g+vsMS 7LcODcyJ5Lk6gs1A+mvIHDP8rA== X-Google-Smtp-Source: ABdhPJwvWaYxLtiQdTjFxqxZ0hGQBViYTZVn6oVs+J+gayqWtyQsVVSB1BUnidGmWIMevchMp6TatQ== X-Received: by 2002:a05:6e02:1d06:: with SMTP id i6mr2758385ila.113.1630677955708; Fri, 03 Sep 2021 07:05:55 -0700 (PDT) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id o2sm2674640ilg.47.2021.09.03.07.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 07:05:55 -0700 (PDT) Subject: Re: [PATCH v6] libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD. To: Hans de Goede , Kate Hsuan , Damien Le Moal Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210903094411.58749-1-hpa@redhat.com> From: Jens Axboe Message-ID: Date: Fri, 3 Sep 2021 08:05:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 9/3/21 8:03 AM, Hans de Goede wrote: > Hi, > > On 9/3/21 2:35 PM, Jens Axboe wrote: >> On 9/3/21 3:44 AM, Kate Hsuan wrote: >>> Many users are reporting that the Samsung 860 and 870 SSD are having >>> various issues when combined with AMD/ATI (vendor ID 0x1002) SATA >>> controllers and only completely disabling NCQ helps to avoid these >>> issues. >>> >>> Always disabling NCQ for Samsung 860/870 SSDs regardless of the host >>> SATA adapter vendor will cause I/O performance degradation with well >>> behaved adapters. To limit the performance impact to ATI adapters, >>> introduce the ATA_HORKAGE_NO_NCQ_ON_ATI flag to force disable NCQ >>> only for these adapters. >>> >>> Also, two libata.force parameters (noncqati and ncqati) are introduced >>> to disable and enable the NCQ for the system which equipped with ATI >>> SATA adapter and Samsung 860 and 870 SSDs. The user can determine NCQ >>> function to be enabled or disabled according to the demand. >>> >>> After verifying the chipset from the user reports, the issue appears >>> on AMD/ATI SB7x0/SB8x0/SB9x0 SATA Controllers and does not appear on >>> recent AMD SATA adapters. The vendor ID of ATI should be 0x1002. >>> Therefore, ATA_HORKAGE_NO_NCQ_ON_AMD was modified to >>> ATA_HORKAGE_NO_NCQ_ON_ATI. >> >> What's this patch against? > > linux-block/for-next + my pre-cursor patch from here: > > https://lore.kernel.org/linux-ide/20210823095220.30157-1-hdegoede@redhat.com/T/#u Still had to fixup a hunk, but it was trivial. In any case, I've applied both now, thanks! -- Jens Axboe