From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
hdegoede@redhat.com, linus.walleij@linaro.org,
linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 6/9] drivers: ata: pata_bk3710: use devm_platform_ioremap_resource()
Date: Tue, 20 Aug 2019 15:30:50 +0200 [thread overview]
Message-ID: <d567bae7-b952-7dcd-976c-13d833c7d0a8@samsung.com> (raw)
In-Reply-To: <1566304548-19972-6-git-send-email-info@metux.net>
On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/pata_bk3710.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_bk3710.c b/drivers/ata/pata_bk3710.c
> index fad95cf..92b036d 100644
> --- a/drivers/ata/pata_bk3710.c
> +++ b/drivers/ata/pata_bk3710.c
> @@ -291,7 +291,6 @@ static void pata_bk3710_chipinit(void __iomem *base)
> static int __init pata_bk3710_probe(struct platform_device *pdev)
> {
> struct clk *clk;
> - struct resource *mem;
> struct ata_host *host;
> struct ata_port *ap;
> void __iomem *base;
> @@ -310,15 +309,13 @@ static int __init pata_bk3710_probe(struct platform_device *pdev)
> /* NOTE: round *down* to meet minimum timings; we count in clocks */
> ideclk_period = 1000000000UL / rate;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> pr_err(DRV_NAME ": failed to get IRQ resource\n");
> return irq;
> }
>
> - base = devm_ioremap_resource(&pdev->dev, mem);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
next prev parent reply other threads:[~2019-08-20 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190820123558epcas1p1d3ad88d04bd6694ab47eb485bd269cc4@epcas1p1.samsung.com>
2019-08-20 12:35 ` [PATCH 1/9] drivers: ata: ahci_octeon: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-08-20 12:35 ` [PATCH 2/9] drivers: ata: ahci_seattle: " Enrico Weigelt, metux IT consult
2019-08-20 13:28 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 3/9] drivers: ata: ahci_tegra: " Enrico Weigelt, metux IT consult
2019-08-20 13:44 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 4/9] drivers: ata: ahci_xgene: " Enrico Weigelt, metux IT consult
2019-08-20 13:45 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 5/9] drivers: ata: libahci_platform: " Enrico Weigelt, metux IT consult
2019-08-20 13:29 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 6/9] drivers: ata: pata_bk3710: " Enrico Weigelt, metux IT consult
2019-08-20 13:30 ` Bartlomiej Zolnierkiewicz [this message]
2019-08-20 12:35 ` [PATCH 7/9] drivers: ata: sata_dwc_460ex: " Enrico Weigelt, metux IT consult
2019-08-20 13:31 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 8/9] drivers: ata: sata_gemini: " Enrico Weigelt, metux IT consult
2019-08-20 13:20 ` Linus Walleij
2019-08-20 13:36 ` Bartlomiej Zolnierkiewicz
2019-08-20 12:35 ` [PATCH 9/9] drivers: ata: sata_rcar: " Enrico Weigelt, metux IT consult
2019-08-20 13:37 ` Bartlomiej Zolnierkiewicz
2019-08-20 13:27 ` [PATCH 1/9] drivers: ata: ahci_octeon: " Bartlomiej Zolnierkiewicz
2019-03-12 9:19 Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 6/9] drivers: ata: pata_bk3710: " Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d567bae7-b952-7dcd-976c-13d833c7d0a8@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=hdegoede@redhat.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).