Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ata: libahci: do not complain in case of deferred probe
@ 2019-07-31 12:26 Miquel Raynal
  2019-07-31 12:29 ` Hans de Goede
  2019-07-31 14:51 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Miquel Raynal @ 2019-07-31 12:26 UTC (permalink / raw)
  To: Hans de Goede, Jens Axboe; +Cc: linux-ide, Miquel Raynal

Retrieving PHYs can deffer the probe, do not spawn an error when
-EPROBE_DEFER is returned, it is normal behavior.

Fixes: b1a9edbda040 ("ata: libahci: allow to use multiple PHYs")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/ata/libahci_platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 72312ad2e142..c25cdbf817f1 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -338,6 +338,9 @@ static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
 		hpriv->phys[port] = NULL;
 		rc = 0;
 		break;
+	case -EPROBE_DEFER:
+		/* Do not complain yet */
+		break;
 
 	default:
 		dev_err(dev,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ata: libahci: do not complain in case of deferred probe
  2019-07-31 12:26 [PATCH] ata: libahci: do not complain in case of deferred probe Miquel Raynal
@ 2019-07-31 12:29 ` Hans de Goede
  2019-07-31 14:51 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2019-07-31 12:29 UTC (permalink / raw)
  To: Miquel Raynal, Jens Axboe; +Cc: linux-ide

Hi,

On 31-07-19 14:26, Miquel Raynal wrote:
> Retrieving PHYs can deffer the probe, do not spawn an error when
> -EPROBE_DEFER is returned, it is normal behavior.
> 
> Fixes: b1a9edbda040 ("ata: libahci: allow to use multiple PHYs")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/ata/libahci_platform.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 72312ad2e142..c25cdbf817f1 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -338,6 +338,9 @@ static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
>   		hpriv->phys[port] = NULL;
>   		rc = 0;
>   		break;
> +	case -EPROBE_DEFER:
> +		/* Do not complain yet */
> +		break;
>   
>   	default:
>   		dev_err(dev,
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ata: libahci: do not complain in case of deferred probe
  2019-07-31 12:26 [PATCH] ata: libahci: do not complain in case of deferred probe Miquel Raynal
  2019-07-31 12:29 ` Hans de Goede
@ 2019-07-31 14:51 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-07-31 14:51 UTC (permalink / raw)
  To: Miquel Raynal, Hans de Goede; +Cc: linux-ide

On 7/31/19 6:26 AM, Miquel Raynal wrote:
> Retrieving PHYs can deffer the probe, do not spawn an error when
> -EPROBE_DEFER is returned, it is normal behavior.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 12:26 [PATCH] ata: libahci: do not complain in case of deferred probe Miquel Raynal
2019-07-31 12:29 ` Hans de Goede
2019-07-31 14:51 ` Jens Axboe

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org linux-ide@archiver.kernel.org
	public-inbox-index linux-ide


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/ public-inbox