linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libahci: do not complain in case of deferred probe
Date: Wed, 31 Jul 2019 14:29:38 +0200	[thread overview]
Message-ID: <defc93ba-5a7f-d568-5a2a-f2b7c4e3690f@redhat.com> (raw)
In-Reply-To: <20190731122651.3378-1-miquel.raynal@bootlin.com>

Hi,

On 31-07-19 14:26, Miquel Raynal wrote:
> Retrieving PHYs can deffer the probe, do not spawn an error when
> -EPROBE_DEFER is returned, it is normal behavior.
> 
> Fixes: b1a9edbda040 ("ata: libahci: allow to use multiple PHYs")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/ata/libahci_platform.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index 72312ad2e142..c25cdbf817f1 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -338,6 +338,9 @@ static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
>   		hpriv->phys[port] = NULL;
>   		rc = 0;
>   		break;
> +	case -EPROBE_DEFER:
> +		/* Do not complain yet */
> +		break;
>   
>   	default:
>   		dev_err(dev,
> 

  reply	other threads:[~2019-07-31 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 12:26 [PATCH] ata: libahci: do not complain in case of deferred probe Miquel Raynal
2019-07-31 12:29 ` Hans de Goede [this message]
2019-07-31 14:51 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=defc93ba-5a7f-d568-5a2a-f2b7c4e3690f@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).