Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk
@ 2019-07-01 16:58 Hans de Goede
  2019-07-02 20:41 ` Martin K. Petersen
  2019-07-02 21:53 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2019-07-01 16:58 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Hans de Goede, linux-ide, Martin K . Petersen

There are several firmware versions between version 2AR10001 and
2BA30001, presumably these also have broken FPDMA_AA activation, so
lets play it safe and apply the quirk to all firmware versions.

Cc: Martin K. Petersen <martin.petersen@oracle.com>
Suggested-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/ata/libata-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4a2dff303865..28c492be0a57 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4462,9 +4462,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 
 	/* drives which fail FPDMA_AA activation (some may freeze afterwards)
 	   the ST disks also have LPM issues */
-	{ "ST1000LM024 HN-M101MBB", "2AR10001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
-						ATA_HORKAGE_NOLPM, },
-	{ "ST1000LM024 HN-M101MBB", "2BA30001",	ATA_HORKAGE_BROKEN_FPDMA_AA |
+	{ "ST1000LM024 HN-M101MBB", NULL,	ATA_HORKAGE_BROKEN_FPDMA_AA |
 						ATA_HORKAGE_NOLPM, },
 	{ "VB0250EAVER",	"HPG7",		ATA_HORKAGE_BROKEN_FPDMA_AA },
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk
  2019-07-01 16:58 [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk Hans de Goede
@ 2019-07-02 20:41 ` Martin K. Petersen
  2019-07-02 21:53 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-07-02 20:41 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Jens Axboe, linux-ide, Martin K . Petersen


Hans,

> There are several firmware versions between version 2AR10001 and
> 2BA30001, presumably these also have broken FPDMA_AA activation, so
> lets play it safe and apply the quirk to all firmware versions.

Looks good.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk
  2019-07-01 16:58 [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk Hans de Goede
  2019-07-02 20:41 ` Martin K. Petersen
@ 2019-07-02 21:53 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-07-02 21:53 UTC (permalink / raw)
  To: Hans de Goede; +Cc: linux-ide, Martin K . Petersen

On 7/1/19 10:58 AM, Hans de Goede wrote:
> There are several firmware versions between version 2AR10001 and
> 2BA30001, presumably these also have broken FPDMA_AA activation, so
> lets play it safe and apply the quirk to all firmware versions.

Applied, thanks Hans.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 16:58 [PATCH] libata: Drop firmware version check from the ST1000LM024 quirk Hans de Goede
2019-07-02 20:41 ` Martin K. Petersen
2019-07-02 21:53 ` Jens Axboe

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org linux-ide@archiver.kernel.org
	public-inbox-index linux-ide


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/ public-inbox