linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ahci: Add support for Dell S140 and later controllers
@ 2021-06-15 19:08 Charles Rose
  2021-06-15 21:44 ` Jens Axboe
  2021-06-17 10:31 ` Hans de Goede
  0 siblings, 2 replies; 3+ messages in thread
From: Charles Rose @ 2021-06-15 19:08 UTC (permalink / raw)
  To: linux-ide, axboe, hdegoede; +Cc: charles.rose, Mika Westerberg

This patch enables support for Dell S140 and later controllers
that use Intel's PCHs configured as PCI_CLASS_STORAGE_RAID.

Reviewed-by: Mika Westerberg <mika.westerberg@intel.com>
Signed-off-by: Charles Rose <charles.rose@dell.com>
---
 drivers/ata/ahci.c      | 4 ++++
 include/linux/pci_ids.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 33192a8f687d..186cbf90c8ea 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -446,6 +446,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
 	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
 
+	/* Dell S140/S150 */
+	{ PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_SUBVENDOR_ID_DELL, PCI_ANY_ID,
+	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
+
 	/* VIA */
 	{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
 	{ PCI_VDEVICE(VIA, 0x6287), board_ahci_vt8251 }, /* VIA VT8251 */
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 4c3fa5293d76..803ec446a729 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -631,6 +631,8 @@
 #define PCI_DEVICE_ID_DELL_RAC4		0x0012
 #define PCI_DEVICE_ID_DELL_PERC5	0x0015
 
+#define PCI_SUBVENDOR_ID_DELL		0x1028
+
 #define PCI_VENDOR_ID_MATROX		0x102B
 #define PCI_DEVICE_ID_MATROX_MGA_2	0x0518
 #define PCI_DEVICE_ID_MATROX_MIL	0x0519
-- 
2.25.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ahci: Add support for Dell S140 and later controllers
  2021-06-15 19:08 [PATCH] ahci: Add support for Dell S140 and later controllers Charles Rose
@ 2021-06-15 21:44 ` Jens Axboe
  2021-06-17 10:31 ` Hans de Goede
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-06-15 21:44 UTC (permalink / raw)
  To: Charles Rose, linux-ide, hdegoede; +Cc: Mika Westerberg

On 6/15/21 1:08 PM, Charles Rose wrote:
> This patch enables support for Dell S140 and later controllers
> that use Intel's PCHs configured as PCI_CLASS_STORAGE_RAID.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ahci: Add support for Dell S140 and later controllers
  2021-06-15 19:08 [PATCH] ahci: Add support for Dell S140 and later controllers Charles Rose
  2021-06-15 21:44 ` Jens Axboe
@ 2021-06-17 10:31 ` Hans de Goede
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-06-17 10:31 UTC (permalink / raw)
  To: Charles Rose, linux-ide, axboe; +Cc: Mika Westerberg

Hi,

On 6/15/21 9:08 PM, Charles Rose wrote:
> This patch enables support for Dell S140 and later controllers
> that use Intel's PCHs configured as PCI_CLASS_STORAGE_RAID.
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@intel.com>
> Signed-off-by: Charles Rose <charles.rose@dell.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/ata/ahci.c      | 4 ++++
>  include/linux/pci_ids.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 33192a8f687d..186cbf90c8ea 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -446,6 +446,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	{ PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>  	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
>  
> +	/* Dell S140/S150 */
> +	{ PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_SUBVENDOR_ID_DELL, PCI_ANY_ID,
> +	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
> +
>  	/* VIA */
>  	{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
>  	{ PCI_VDEVICE(VIA, 0x6287), board_ahci_vt8251 }, /* VIA VT8251 */
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 4c3fa5293d76..803ec446a729 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -631,6 +631,8 @@
>  #define PCI_DEVICE_ID_DELL_RAC4		0x0012
>  #define PCI_DEVICE_ID_DELL_PERC5	0x0015
>  
> +#define PCI_SUBVENDOR_ID_DELL		0x1028
> +
>  #define PCI_VENDOR_ID_MATROX		0x102B
>  #define PCI_DEVICE_ID_MATROX_MGA_2	0x0518
>  #define PCI_DEVICE_ID_MATROX_MIL	0x0519
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-17 10:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 19:08 [PATCH] ahci: Add support for Dell S140 and later controllers Charles Rose
2021-06-15 21:44 ` Jens Axboe
2021-06-17 10:31 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).