From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: davidcomponentone@gmail.com
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Guang <yang.guang5@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] ata: replace snprintf in show functions with sysfs_emit
Date: Thu, 2 Dec 2021 13:19:05 +0900 [thread overview]
Message-ID: <f74c3567-64ff-4bce-89f5-192a1ae9fc45@opensource.wdc.com> (raw)
In-Reply-To: <2fbce7707eff3bfebf38138899e900ee8c619931.1638155918.git.yang.guang5@zte.com.cn>
On 2021/11/30 9:04, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> coccinelle report：
> ./drivers/ata/libata-sata.c:830:8-16:
> WARNING: use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> ---
> drivers/ata/libata-sata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
> index 5b78e86e3459..b9c77885b872 100644
> --- a/drivers/ata/libata-sata.c
> +++ b/drivers/ata/libata-sata.c
> @@ -827,7 +827,7 @@ static ssize_t ata_scsi_lpm_show(struct device *dev,
> if (ap->target_lpm_policy >= ARRAY_SIZE(ata_lpm_policy_names))
> return -EINVAL;
>
> - return snprintf(buf, PAGE_SIZE, "%s\n",
> + return sysfs_emit(buf, "%s\n",
> ata_lpm_policy_names[ap->target_lpm_policy]);
> }
> DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
>
Applied to for-5.16-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-12-02 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 0:04 [PATCH] ata: replace snprintf in show functions with sysfs_emit davidcomponentone
2021-12-02 4:19 ` Damien Le Moal [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-13 3:25 Qing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f74c3567-64ff-4bce-89f5-192a1ae9fc45@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=davidcomponentone@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.guang5@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).