linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Michael Schmitz <schmitzmic@gmail.com>,
	linux-m68k@vger.kernel.org, linux-ide@vger.kernel.org
Cc: geert@linux-m68k.org, b.zolnierkie@samsung.com
Subject: Re: [PATCH RFC 1/2] m68k/atari: add platform device for Falcon IDE port
Date: Sun, 23 Jun 2019 12:06:55 +0300	[thread overview]
Message-ID: <f820e822-deae-87a3-cb05-0ca2ba4608f4@cogentembedded.com> (raw)
In-Reply-To: <1561063642-13900-2-git-send-email-schmitzmic@gmail.com>

Hello!

On 20.06.2019 23:47, Michael Schmitz wrote:

> Autoloading of Falcon IDE driver modules requires converting
> these drivers to platform drivers.
> 
> Add platform device for Falcon IDE interface in Atari platform
> setup code in preparation for this.
> 
> Add Falcon IDE base address in Atari hardware address header.
> 
> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> ---
>   arch/m68k/atari/config.c        |   20 ++++++++++++++++++++
>   arch/m68k/include/asm/atarihw.h |    6 ++++++
>   2 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
> index ca8469e..2d7133a 100644
> --- a/arch/m68k/atari/config.c
> +++ b/arch/m68k/atari/config.c
> @@ -896,6 +896,21 @@ static void isp1160_delay(struct device *dev, int delay)
>   };
>   #endif
>   
> +#if IS_ENABLED(CONFIG_PATA_FALCON)
> +static const struct resource atari_falconide_rsrc[] __initconst = {
> +	{
> +		.flags = IORESOURCE_MEM,
> +		.start = FALCON_IDE_BASE,
> +		.end   = FALCON_IDE_BASE+0x40,

    You probably forgot to subtract 1 here...

> +	},
> +	{
> +		.flags = IORESOURCE_IRQ,
> +		.start = IRQ_MFP_FSCSI,
> +		.end   = IRQ_MFP_FSCSI,
> +	},
> +};
> +#endif
> +
>   int __init atari_platform_init(void)
>   {
>   	int rv = 0;
[...]

MBR, Sergei

  reply	other threads:[~2019-06-23  9:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMuHMdUcUqWWGNngNV3EpEq5wSsf5qTVeZvTB9gX1e26Jrq1xA@mail.gmail.com>
2019-06-20 20:47 ` [PATCH RFC 0/2] Convert Atari Falcon IDE driver to platform device Michael Schmitz
2019-06-20 20:47 ` [PATCH RFC 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz
2019-06-23  9:06   ` Sergei Shtylyov [this message]
2019-06-25  3:47     ` Michael Schmitz
2019-06-25  7:51   ` Geert Uytterhoeven
2019-06-25 20:51     ` Michael Schmitz
2019-06-20 20:47 ` [PATCH RFC 2/2] drivers/ata: convert pata_falcon to arch platform device Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f820e822-deae-87a3-cb05-0ca2ba4608f4@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).