linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani  <suganath-prabu.subramani@broadcom.com>
Subject: Re: [PATCH v2 5/9] libata: cleanup NCQ priority handling
Date: Fri, 6 Aug 2021 11:09:18 +0200	[thread overview]
Message-ID: <f975ceba-d703-25aa-2d4c-65f60a5bafa0@suse.de> (raw)
In-Reply-To: <20210806074252.398482-6-damien.lemoal@wdc.com>

On 8/6/21 9:42 AM, Damien Le Moal wrote:
> The ata device flag ATA_DFLAG_NCQ_PRIO indicates if a device supports
> the NCQ Priority feature while the ATA_DFLAG_NCQ_PRIO_ENABLE device
> flag indicates if the feature is enabled. Enabling NCQ priority use is
> controlled by the user through the device sysfs attribute
> ncq_prio_enable. As a result, the ATA_DFLAG_NCQ_PRIO flag should not be
> cleared when ATA_DFLAG_NCQ_PRIO_ENABLE is not set as the device still
> supports the feature even after the user disables it. This leads to the
> following cleanups:
> - In ata_build_rw_tf(), set a command high priority bit based on the
>   ATA_DFLAG_NCQ_PRIO_ENABLE flag, not on the ATA_DFLAG_NCQ flag. That
>   is, set a command high priority only if the user enabled NCQ priority
>   use.
> - In ata_dev_config_ncq_prio(), ATA_DFLAG_NCQ_PRIO should not be cleared
>   if ATA_DFLAG_NCQ_PRIO_ENABLE is not set. If the device does not
>   support NCQ priority, both ATA_DFLAG_NCQ_PRIO and
>   ATA_DFLAG_NCQ_PRIO_ENABLE must be cleared.
> 
> With the above ata_dev_config_ncq_prio() change, ATA_DFLAG_NCQ_PRIO flag
> is set on device scan and revalidation. There is no need to trigger a
> device revalidation in ata_ncq_prio_enable_store() when the user enables
> the use of NCQ priority. Remove the revalidation code from that funciton
> to simplify it. Also change the return value from -EIO to -EINVAL when a
> user tries to enable NCQ priority for a device that does not support
> this feature.  While at it, also simplify ata_ncq_prio_enable_show().
> 
> Overall, there is no functional change introduced by this patch.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  drivers/ata/libata-core.c | 32 ++++++++++++++------------------
>  drivers/ata/libata-sata.c | 37 ++++++++++++-------------------------
>  2 files changed, 26 insertions(+), 43 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer

  reply	other threads:[~2021-08-06  9:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  7:42 [PATCH v2 0/9] libata cleanups and improvements Damien Le Moal
2021-08-06  7:42 ` [PATCH v2 1/9] libata: fix ata_host_alloc_pinfo() Damien Le Moal
2021-08-06  8:49   ` Hannes Reinecke
2021-08-06 14:25   ` James Bottomley
2021-08-06 14:31     ` Damien Le Moal
2021-08-06  7:42 ` [PATCH v2 2/9] libata: fix ata_host_start() Damien Le Moal
2021-08-06  8:50   ` Hannes Reinecke
2021-08-06 14:31   ` James Bottomley
2021-08-06 14:33     ` Damien Le Moal
2021-08-07  3:32     ` Damien Le Moal
2021-08-06  7:42 ` [PATCH v2 3/9] libata: cleanup device sleep capability detection Damien Le Moal
2021-08-06  8:50   ` Hannes Reinecke
2021-08-06  7:42 ` [PATCH v2 4/9] libata: cleanup ata_dev_configure() Damien Le Moal
2021-08-06  9:07   ` Hannes Reinecke
2021-08-06  9:12     ` Damien Le Moal
2021-08-06  9:28       ` Hannes Reinecke
2021-08-06  9:32         ` Damien Le Moal
2021-08-06  7:42 ` [PATCH v2 5/9] libata: cleanup NCQ priority handling Damien Le Moal
2021-08-06  9:09   ` Hannes Reinecke [this message]
2021-08-06  7:42 ` [PATCH v2 6/9] libata: fix ata_read_log_page() warning Damien Le Moal
2021-08-06  9:10   ` Hannes Reinecke
2021-08-06  7:42 ` [PATCH v2 7/9] libata: print feature list on device scan Damien Le Moal
2021-08-06  9:11   ` Hannes Reinecke
2021-08-06  7:42 ` [PATCH v2 8/9] libahci: Introduce ncq_prio_supported sysfs sttribute Damien Le Moal
2021-08-06  7:42 ` [PATCH v2 9/9] scsi: mpt3sas: Introduce sas_ncq_prio_supported " Damien Le Moal
2021-08-06  9:12   ` Hannes Reinecke
2021-08-06  9:16     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f975ceba-d703-25aa-2d4c-65f60a5bafa0@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --subject='Re: [PATCH v2 5/9] libata: cleanup NCQ priority handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).