From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Simon Arlott <simon@octiron.net>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Park Ju Hyung <qkrwngud825@gmail.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs
Date: Wed, 15 Jul 2020 16:53:14 -0400 [thread overview]
Message-ID: <yq1blkgo6y0.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <9324ef33-eedd-b965-37e8-b82e06778aab@0882a8b5-c6c3-11e9-b005-00805fc181fe> (Simon Arlott's message of "Wed, 15 Jul 2020 12:13:24 +0100")
Hi Simon!
> Despite the unsubstantiated claim from Samsung that "the improved
> queued trim enhances Linux compatibility" this does not appear to be
> true, even on Intel SATA controllers:
I am aware of several people using 860 drives with queued TRIM. And I
haven't heard any complaints outside of the bug you referenced.
Also, I have tested both 860 2.5" Pro and 860 mSATA EVO on a few
different systems in my lab without any problems. See:
https://lore.kernel.org/stable/yq1h87du82d.fsf@oracle.com/T/
I really wish we had some more data to work with :(
Lacking a proper heuristic I guess we don't have any choice to disable
the feature. But that's sad news for the people who currently don't have
problems since their performance will inevitably suffer.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-07-15 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 11:13 [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs Simon Arlott
2020-07-15 17:37 ` Ju Hyung Park
2020-07-15 20:53 ` Martin K. Petersen [this message]
2020-07-15 21:12 ` Simon Arlott
2020-07-15 22:03 ` Ju Hyung Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blkgo6y0.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qkrwngud825@gmail.com \
--cc=simon@octiron.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).