From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Kate Hsuan <hpa@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@wdc.com>,
Tor Vic <torvic9@mailbox.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] libata: Add ATA_HORKAGE_NO_NCQ_ON_AMD for Samsung 860 and 870 SSD.
Date: Thu, 02 Sep 2021 15:01:55 -0400 [thread overview]
Message-ID: <yq1h7f24y6f.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <3e26e7a5-0d99-b993-d5ce-aa517e1bf1bb@redhat.com> (Hans de Goede's message of "Thu, 2 Sep 2021 18:07:10 +0200")
Hans,
> So it looks like we actually need to disable NCQ for Samsung 860/870
> devices when the SATA controller has a vendor-id of PCI_VENDOR_ID_ATI
> rather then AMD.
That's another great data point!
I wonder if there actually is a Samsung problem (given that these drives
work fine on other controllers). Or if it is just the queued trim
handling that's broken on 1002:4391 controllers from ATI.
When I originally experimented with queued trim I had systems I could
not get to work. But queued trim worked fine when the same drives were
connected to more modern chipsets (note that this was "did not work at
all" as opposed to "randomly corrupting data").
Do we have any evidence at all of queued trim working with non-Samsung
drives on these controllers? Not sure how many modern SATA drives
actually implement this feature. Maybe the reason we see Samsung drives
in the bug reports is due to a combination of popularity and the fact
that these drives actually implement queued trim support.
> So lets wait a bit for some more info to become available and then
> I think we need a v6 with s/AMD/ATI/ (everywhere, also in the name
> of the horkage-flag, the cmdline options, etc.).
Sounds good!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-02 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 15:16 [PATCH v5] libata: Add ATA_HORKAGE_NO_NCQ_ON_AMD for Samsung 860 and 870 SSD Kate Hsuan
2021-09-02 16:07 ` Hans de Goede
2021-09-02 19:01 ` Martin K. Petersen [this message]
2021-09-02 20:46 ` Hans de Goede
2021-09-02 20:50 ` Hans de Goede
2021-09-03 3:21 ` Martin K. Petersen
2021-09-19 14:24 ` Tor Vic
2021-09-19 15:27 ` Hans de Goede
2021-09-19 16:27 ` Tor Vic
2021-09-19 16:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h7f24y6f.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvic9@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).