From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F051C43219 for ; Fri, 3 May 2019 14:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E26F2075E for ; Fri, 3 May 2019 14:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbfECOji convert rfc822-to-8bit (ORCPT ); Fri, 3 May 2019 10:39:38 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:23655 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfECOjh (ORCPT ); Fri, 3 May 2019 10:39:37 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-113-LyrG2MGFMYeVaRNCuyPBFw-1; Fri, 03 May 2019 15:39:35 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 3 May 2019 15:39:32 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 3 May 2019 15:39:32 +0100 From: David Laight To: 'Philippe Schenker' , "linux-iio@vger.kernel.org" , Jonathan Cameron , "Stefan Agner" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler CC: Philippe Schenker , Max Krummenacher , Alexandre Torgue , "linux-kernel@vger.kernel.org" , Lee Jones , Maxime Coquelin , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Topic: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Index: AQHVAbg3A7HWDrzd+kO5dj2pSSFp8qZZeDWw Date: Fri, 3 May 2019 14:39:32 +0000 Message-ID: <0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com> References: <20190503135725.9959-1-dev@pschenker.ch> <20190503135725.9959-2-dev@pschenker.ch> In-Reply-To: <20190503135725.9959-2-dev@pschenker.ch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: LyrG2MGFMYeVaRNCuyPBFw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Philippe Schenker > Sent: 03 May 2019 14:57 > In some cases, the wait_completion got interrupted. This caused the > error-handling to mutex_unlock the function. The before turned on > interrupt then got called anyway. In the ISR then completion() > was called causing problems. > > Making this wait_completion non interruptible solves the problem. Won't the same thing happen if the interrupt occurs just after the timeout? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)