* [PATCH] iio: trigger: stm32-timer: remove unnecessary update event
@ 2019-11-21 11:05 Fabrice Gasnier
2019-11-23 16:43 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2019-11-21 11:05 UTC (permalink / raw)
To: jic23
Cc: linux-arm-kernel, linux-kernel, benjamin.gaignard,
mcoquelin.stm32, alexandre.torgue, fabrice.gasnier, linux-iio,
lars, knaack.h, pmeerw, linux-stm32
There is no need to explicitly generate update event to update
timer master mode.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/iio/trigger/stm32-timer-trigger.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
index a5dfe65..2e0d32a 100644
--- a/drivers/iio/trigger/stm32-timer-trigger.c
+++ b/drivers/iio/trigger/stm32-timer-trigger.c
@@ -297,9 +297,6 @@ static ssize_t stm32_tt_store_master_mode(struct device *dev,
strlen(master_mode_table[i]))) {
regmap_update_bits(priv->regmap, TIM_CR2, mask,
i << shift);
- /* Make sure that registers are updated */
- regmap_update_bits(priv->regmap, TIM_EGR,
- TIM_EGR_UG, TIM_EGR_UG);
return len;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: trigger: stm32-timer: remove unnecessary update event
2019-11-21 11:05 [PATCH] iio: trigger: stm32-timer: remove unnecessary update event Fabrice Gasnier
@ 2019-11-23 16:43 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-11-23 16:43 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: linux-arm-kernel, linux-kernel, benjamin.gaignard,
mcoquelin.stm32, alexandre.torgue, linux-iio, lars, knaack.h,
pmeerw, linux-stm32
On Thu, 21 Nov 2019 12:05:17 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> There is no need to explicitly generate update event to update
> timer master mode.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it
Thanks,
Jonathan
> ---
> drivers/iio/trigger/stm32-timer-trigger.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index a5dfe65..2e0d32a 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -297,9 +297,6 @@ static ssize_t stm32_tt_store_master_mode(struct device *dev,
> strlen(master_mode_table[i]))) {
> regmap_update_bits(priv->regmap, TIM_CR2, mask,
> i << shift);
> - /* Make sure that registers are updated */
> - regmap_update_bits(priv->regmap, TIM_EGR,
> - TIM_EGR_UG, TIM_EGR_UG);
> return len;
> }
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-23 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 11:05 [PATCH] iio: trigger: stm32-timer: remove unnecessary update event Fabrice Gasnier
2019-11-23 16:43 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).