From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "charles-antoine.couret@essensium.com"
<charles-antoine.couret@essensium.com>,
"andrea.merello@gmail.com" <andrea.merello@gmail.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 0/4] Fixes for ad7949
Date: Fri, 13 Sep 2019 07:24:23 +0000 [thread overview]
Message-ID: <1f13820761bbdb4db685a90e9bcf35a388b246cf.camel@analog.com> (raw)
In-Reply-To: <20190912144310.7458-1-andrea.merello@gmail.com>
On Thu, 2019-09-12 at 16:43 +0200, Andrea Merello wrote:
> [External]
>
> This patch series fixes ad7949 driver incorrectly read data, simplify the
> code, and enforces device timing constraints.
>
> This has been tested on a UltraZed SOM + a custom carrier equipped with
> several AD7689 A/Ds. Patches have been developed on a Xilinx upstream
> kernel and then rebased on linux-next kernel.
>
Hey,
Thanks for the patches.
Added Charles-Antoine to also take a look.
Apologies for not thinking of adding him sooner.
I typically try to review changes for ADI parts, but he wrote it, so he may have more input than I do.
Jonathan will likely also take a look.
If it's agreed, I would say to at least take the first patch ("iio: ad7949: kill pointless "readback"-handling code")
now and see about the rest.
The rest are a bit more open to discussion, so a v2 may happen.
Thanks
Alex
> Andrea Merello (4):
> iio: ad7949: kill pointless "readback"-handling code
> iio: ad7949: fix incorrect SPI xfer len
> iio: ad7949: fix SPI xfer delays
> iio: ad7949: fix channels mixups
>
> drivers/iio/adc/ad7949.c | 64 +++++++++++++---------------------------
> 1 file changed, 21 insertions(+), 43 deletions(-)
>
> --
> 2.17.1
next prev parent reply other threads:[~2019-09-13 7:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 14:43 [PATCH 0/4] Fixes for ad7949 Andrea Merello
2019-09-12 14:43 ` [PATCH 1/4] iio: ad7949: kill pointless "readback"-handling code Andrea Merello
2019-09-13 6:37 ` Ardelean, Alexandru
2019-09-15 10:26 ` Jonathan Cameron
2019-09-12 14:43 ` [PATCH 2/4] iio: ad7949: fix incorrect SPI xfer len Andrea Merello
2019-09-13 6:46 ` Ardelean, Alexandru
2019-09-13 7:56 ` Andrea Merello
2019-09-13 8:28 ` Ardelean, Alexandru
2019-09-15 10:36 ` Jonathan Cameron
2019-09-16 7:51 ` Ardelean, Alexandru
2019-09-21 17:16 ` Jonathan Cameron
2019-09-12 14:43 ` [PATCH 3/4] iio: ad7949: fix SPI xfer delays Andrea Merello
2019-09-13 6:59 ` Ardelean, Alexandru
2019-09-13 8:23 ` Andrea Merello
2019-09-13 8:43 ` Ardelean, Alexandru
2019-09-12 14:43 ` [PATCH 4/4] iio: ad7949: fix channels mixups Andrea Merello
2019-09-13 7:19 ` Ardelean, Alexandru
2019-09-13 8:30 ` Andrea Merello
2019-09-13 11:30 ` Couret Charles-Antoine
2019-09-13 11:40 ` Andrea Merello
2019-09-20 7:45 ` Andrea Merello
2019-09-21 17:12 ` Jonathan Cameron
2019-09-23 8:21 ` Andrea Merello
2019-10-05 9:55 ` Jonathan Cameron
[not found] ` <CAN8YU5PRO5Y5EeEj2SZGm5XfuKSB1rtS7nKdu6wWxXYDOfexqw@mail.gmail.com>
2019-10-22 8:56 ` Jonathan Cameron
2019-11-04 14:12 ` Andrea Merello
2019-11-09 11:58 ` Jonathan Cameron
2019-11-12 15:09 ` Couret Charles-Antoine
2019-12-02 14:13 ` [v2] " Andrea Merello
2019-12-02 15:36 ` Couret Charles-Antoine
2019-12-04 11:06 ` Jonathan Cameron
2019-12-04 11:13 ` Couret Charles-Antoine
2019-12-06 16:45 ` Jonathan Cameron
2019-09-13 7:24 ` Ardelean, Alexandru [this message]
2019-09-13 14:00 ` [PATCH 0/4] Fixes for ad7949 Couret Charles-Antoine
2019-09-15 10:49 ` Jonathan Cameron
2019-09-16 7:39 ` Andrea Merello
2019-09-16 7:48 ` Ardelean, Alexandru
2019-09-16 7:50 ` Ardelean, Alexandru
2019-09-16 7:34 ` Andrea Merello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f13820761bbdb4db685a90e9bcf35a388b246cf.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andrea.merello@gmail.com \
--cc=charles-antoine.couret@essensium.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).