From: Lee Jones <lee.jones@linaro.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability
Date: Wed, 25 Jul 2018 06:26:21 +0100 [thread overview]
Message-ID: <20180725052621.GB5835@dell> (raw)
In-Reply-To: <2236aa96-ca56-fa30-157d-2f484c6968cc@ti.com>
On Tue, 24 Jul 2018, Vignesh R wrote:
> On Monday 23 July 2018 11:07 AM, Lee Jones wrote:
> > On Wed, 18 Jul 2018, Dmitry Torokhov wrote:
> >
> >> On Wed, Jul 18, 2018 at 08:47:36AM +0100, Lee Jones wrote:
> >>> On Tue, 17 Jul 2018, Vignesh R wrote:
> >>>
> >>>> Hi Dmitry,
> >>>>
> >>>> On Saturday 30 June 2018 04:03 PM, Vignesh R wrote:
> >>>>> On AM335x, resistive TSC can wakeup the system from low power state.
> >>>>> Currently, parent MFD device is marked as wakeup source, which is
> >>>>> inaccurate as its the touch event generated by TSC thats the wakeup
> >>>>> source. This series moves all wakeup related calls to operate on TSC
> >>>>> device instead of MFD. It also marks TSC IRQ as wakeup capable, so that
> >>>>> its not disabled during system suspend.
> >>>>>
> >>>>> This series is based on Dmitry's comments here:
> >>>>> https://lkml.org/lkml/2018/4/24/65
> >>>>>
> >>>>> There are many new patches in this series, hence did not mark this as v4.
> >>>>>
> >>>>> Vignesh R (5):
> >>>>> mfd: ti_am335x_tscadc: Don't mark TSCADC MFD as wakeup capable
> >>>>> Input: ti_am335x_tsc: Mark TSC device as wakeup source
> >>>>> mfd: ti_am335x_tscadc: Keep ADC interface on if child is wakeup
> >>>>> capable
> >>>>> iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally
> >>>>> Input: ti_am335x_tsc: Mark IRQ as wakeup capable
> >>>>>
> >>>>> drivers/iio/adc/ti_am335x_adc.c | 12 ++++--------
> >>>>> drivers/input/touchscreen/ti_am335x_tsc.c | 22 +++++++++++++++++-----
> >>>>> drivers/mfd/ti_am335x_tscadc.c | 14 +++++++++++++-
> >>>>> 3 files changed, 34 insertions(+), 14 deletions(-)
> >>>>>
> >>>>
> >>>> Gentle ping... Could you review/pick this series? MFD amd IIO bits are
> >>>> already ACKed
> >>>
> >>> MFD patches are reviewed "for my own reference" meaning that we
> >>> haven't yet agreed on a merge plan yet.
> >>
> >> I think this series makes sense to be pushed through a single tree as
> >> opposed to being spread between 3, even if it could technically be
> >> possible. It looks like Jonathan is fine with going it through either
> >> his or some other tree, I am fine with it going through MFD.
> >
> > I'm happy either way.
> >
> Thanks Dmitry, Jonathan and Lee Jones!
>
> Could this be applied to one of the trees now? MFD perhaps?
It'll be applied, when it's applied. ;)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-07-25 6:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 10:33 [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability Vignesh R
2018-06-30 10:33 ` [PATCH 1/5] mfd: ti_am335x_tscadc: Don't mark TSCADC MFD as wakeup capable Vignesh R
2018-07-04 7:38 ` Lee Jones
2018-10-09 10:29 ` Lee Jones
2018-06-30 10:33 ` [PATCH 2/5] Input: ti_am335x_tsc: Mark TSC device as wakeup source Vignesh R
2018-07-18 17:06 ` Dmitry Torokhov
2018-10-09 10:29 ` Lee Jones
2018-06-30 10:33 ` [PATCH 3/5] mfd: ti_am335x_tscadc: Keep ADC interface on if child is wakeup capable Vignesh R
2018-07-04 7:39 ` Lee Jones
2018-10-09 10:30 ` Lee Jones
2018-06-30 10:33 ` [PATCH 4/5] iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally Vignesh R
2018-06-30 15:18 ` Jonathan Cameron
2018-07-04 14:40 ` Vignesh R
2018-10-09 10:30 ` Lee Jones
2018-06-30 10:33 ` [PATCH 5/5] Input: ti_am335x_tsc: Mark IRQ as wakeup capable Vignesh R
2018-07-18 17:06 ` Dmitry Torokhov
2018-10-09 10:30 ` Lee Jones
2018-07-17 11:45 ` [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability Vignesh R
2018-07-18 7:47 ` Lee Jones
2018-07-18 17:09 ` Dmitry Torokhov
2018-07-21 18:09 ` Jonathan Cameron
2018-07-23 5:37 ` Lee Jones
2018-07-24 17:33 ` Vignesh R
2018-07-25 5:26 ` Lee Jones [this message]
2018-09-28 6:12 ` Vignesh R
2018-10-05 5:11 ` Vignesh R
2018-10-09 10:33 ` [GIT PULL] Immutable branch between MFD, IIO and Input due for the v4.20 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725052621.GB5835@dell \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).