Linux-IIO Archive on lore.kernel.org
 help / Atom feed
* [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake
@ 2018-12-20 23:46 Amir Mahdi Ghorbanian
  2018-12-22 17:33 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Amir Mahdi Ghorbanian @ 2018-12-20 23:46 UTC (permalink / raw)
  To: lars
  Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio,
	linux-kernel, Amir Mahdi Ghorbanian

Fixed a coding style mistake by adding the SPDX identifier tag to the
first line of the code

Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
---
 drivers/staging/iio/accel/adis16203.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index 5cc96c80..4ae5b74 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -1,9 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * ADIS16203 Programmable 360 Degrees Inclinometer
  *
  * Copyright 2010 Analog Devices Inc.
  *
- * Licensed under the GPL-2 or later.
  */
 
 #include <linux/delay.h>
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake
  2018-12-20 23:46 [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake Amir Mahdi Ghorbanian
@ 2018-12-22 17:33 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-12-22 17:33 UTC (permalink / raw)
  To: Amir Mahdi Ghorbanian
  Cc: lars, Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio,
	linux-kernel

On Thu, 20 Dec 2018 15:46:53 -0800
Amir Mahdi Ghorbanian <indigoomega021@gmail.com> wrote:

> Fixed a coding style mistake by adding the SPDX identifier tag to the
> first line of the code
> 
> Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
Two things.  It's not a 'mistake' as this driver massively predates the use of
SPDX tags!  Also, there is a problem here as it's current licensing is
inconsistent.  The MODULE_LICENSE is GPL-2.0 which would be GPL-2.0 (no +)
but the original comment was +.

Michael, do you want to take a view on this one?  Copyright is Analog's
so should be fine if you say what is preferred.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/accel/adis16203.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index 5cc96c80..4ae5b74 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -1,9 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * ADIS16203 Programmable 360 Degrees Inclinometer
>   *
>   * Copyright 2010 Analog Devices Inc.
>   *
> - * Licensed under the GPL-2 or later.
>   */
>  
>  #include <linux/delay.h>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 23:46 [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake Amir Mahdi Ghorbanian
2018-12-22 17:33 ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox