From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, mark.rutland@arm.com, yuenn@google.com,
venture@google.com, brendanhiggins@google.com,
avifishman70@gmail.com, joel@jms.id.au,
linux-iio@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: iio: add NPCM ADC documentation
Date: Thu, 3 Jan 2019 15:14:47 -0600 [thread overview]
Message-ID: <20190103211447.GA4618@bogus> (raw)
In-Reply-To: <20181224164755.286932-2-tmaimon77@gmail.com>
On Mon, Dec 24, 2018 at 06:47:54PM +0200, Tomer Maimon wrote:
> Added device tree binding documentation for Nuvoton BMC
> NPCM Analog-to-Digital Converter(ADC).
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt
> new file mode 100644
> index 000000000000..6f0843d837cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm-adc.txt
> @@ -0,0 +1,35 @@
> +Nuvoton NPCM Analog to Digital Converter (ADC)
> +
> +The NPCM ADC is a 10-bit converter for eight channel inputs.
> +
> +Required properties:
> +- compatible : "nuvoton,npcm750-adc" for the NPCM7XX BMC.
> +- reg : specifies physical base address and size of the registers.
> +- interrupts : Contain the ADC interrupt with flags for falling edge.
> +
> +Optional properties:
> +- clocks : phandle of ADC reference clock, in case the clock is not
> + added the ADC will use the default ADC sample rate.
> +- vref-supply : The regulator supply ADC reference voltage, in case the
> + vref-supply is not added the ADC will use internal voltage
> + reference.
> +
> +Required Node in the NPCM7xx BMC:
> +An additional register is present in the NPCM7xx SOC which is
> +assumed to be in the same device tree, with and marked as
> +compatible with "nuvoton,npcm750-rst".
> +
> +Example:
> +
> +adc: adc@f000c000 {
> + compatible = "nuvoton,npcm750-adc";
> + reg = <0xf000c000 0x8>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk NPCM7XX_CLK_ADC>;
> +};
> +
> +rst: rst@f0801000 {
Why is this node here?
> + compatible = "nuvoton,npcm750-rst", "syscon",
> + "simple-mfd";
> + reg = <0xf0801000 0x6C>;
> +};
> --
> 2.14.1
>
next prev parent reply other threads:[~2019-01-03 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 16:47 [PATCH v1 0/2] iio: adc: npcm: add NPCm ADC driver Tomer Maimon
2018-12-24 16:47 ` [PATCH v1 1/2] dt-binding: iio: add NPCM ADC documentation Tomer Maimon
2019-01-03 21:14 ` Rob Herring [this message]
2019-01-05 16:57 ` Jonathan Cameron
2018-12-24 16:47 ` [PATCH v1 2/2] iio: adc: add NPCM ADC driver Tomer Maimon
2018-12-25 22:00 ` Peter Meerwald-Stadler
2019-01-05 17:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103211447.GA4618@bogus \
--to=robh@kernel.org \
--cc=avifishman70@gmail.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pmeerw@pmeerw.net \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).