From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6812AC61CE8 for ; Sat, 19 Jan 2019 16:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3686F2086D for ; Sat, 19 Jan 2019 16:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547916622; bh=3ChO+WKh/he7Cxyt1gTDNM/CZpiuoW3aAr56vsg10Ws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=r2vJLkTbQSubK9dCaJci+82fmvjqsS2Q9g1CKoB/u+3fq8W5rLXRYoLb83lLaUmCW 3CzOZ55lg75bfivMfZ9zX6arxe6MK8x40uBcy2IH2hjzW+8A46t+OssYIz+LMtZsnc xwrOJcaC1d8hgGhw+Cs99SBW4jackpFd0nziynAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728345AbfASQuV (ORCPT ); Sat, 19 Jan 2019 11:50:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:35250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbfASQuV (ORCPT ); Sat, 19 Jan 2019 11:50:21 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0124B20823; Sat, 19 Jan 2019 16:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547916620; bh=3ChO+WKh/he7Cxyt1gTDNM/CZpiuoW3aAr56vsg10Ws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oZVDSJxVhZTO+zqYOGvku6apoDWcldlP+ygWSpe75OmrC6wKJLOsdx9ZSMhpVbpzW R6gLoMJCB8HfDFPYnddRIqgoTw9HwLksRWVANiBuN5DpRlhKnFbTWwpJOKBGv9BrNd XInKH71BHr4BG9rJhVSLLPHtcYR/wPuRyJgXVomU= Date: Sat, 19 Jan 2019 16:50:15 +0000 From: Jonathan Cameron To: Daniel Drake Cc: Denis CIOCCA , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "linux-iio@vger.kernel.org" , "linux@endlessm.com" , "lorenzo.bianconi83@gmail.com" , "hadess@hadess.net" , "hdegoede@redhat.com" Subject: Re: [PATCH 2/2] iio: st_accel: use ACPI orientation data Message-ID: <20190119165015.2b44a64d@archlinux> In-Reply-To: References: <20181220065933.25964-1-drake@endlessm.com> <20181220065933.25964-2-drake@endlessm.com> <20181222180914.6d3b5e5e@archlinux> <20190112191305.103daa46@archlinux> <49fe1df26d70489ca3b3c52cb5cf561c@SFHDAG2NODE1.st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 15 Jan 2019 11:09:51 +0800 Daniel Drake wrote: > Hi Denis, > > On Tue, Jan 15, 2019 at 8:18 AM Denis CIOCCA wrote: > > I am not familiar with ACPI and I am not sure why axis orientation is not following the standard there. > > What I wonder is if this is related to SMO8840, Acer or in general to ST accelerometers integration. Your patch seems to be fine technically but are you able to confirm it will works even outside the 3 parts tested? The other accel supported by ACPI probing SMO8A90 is affected also? > > The _ONT data format was explained to us by a vendor support contact > at ST. (however, the fact that the _ONT transformation must be applied > after first applying another translation was determined experimentally > by me). > > We have seen this _ONT data present in ACPI tables from multiple > product vendors, on SMO8820, SMO8821 and SMO8840 devices, so I believe > there is no doubt that it is a ST-specific thing. > > The specific transformation behaviour in my patch has only been tested > on products with SMO8840 though, since those are the only ones we have > on hand. > > Daniel I suspect we aren't going to come to a firm conclusion on this any time soon. As it only effects devices that do provide _ONT, it is fairly unlikely to cause a regression. Ideally we would know if it worked on the other devices where this is known to exist but such is life. If people agree that I'm right in patch 1 not being necessary and we don't have any objections to merging this I'll do so, probably next weekend now. Thanks, Jonathan