From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DD8C282C4 for ; Sat, 9 Feb 2019 16:14:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B2FA21919 for ; Sat, 9 Feb 2019 16:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549728855; bh=Ut8FDjzNN6TjO6xww+pYGdChn5uhNEOVqQD6ttebd9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HIbHryPYlCfXNpb6dY6pMoFPa76swlj4ToYiv7MBr1YNRe8xtV0qE4PHLILYA49DD 4NBuouOX86metDK/rH7jzCPQX0PF54XHZTrtqqbjpOs+CD2s7lAHc92D5CONhVQAD/ xlbuLptPkldL80CNaORP229Qx6bGlM+nQk0cvUkc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfBIQOO (ORCPT ); Sat, 9 Feb 2019 11:14:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:60788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbfBIQOO (ORCPT ); Sat, 9 Feb 2019 11:14:14 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AEC3E21773; Sat, 9 Feb 2019 16:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549728853; bh=Ut8FDjzNN6TjO6xww+pYGdChn5uhNEOVqQD6ttebd9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nKPI+ByK8xUfPfJYGkLaX2UAFFxWRU71Tl+ft1LDuJyDnL/v84zzx1Wrh1Zm+6vCn bHg/WxCb6MOnYw13cxyDk6nOmFhA95zzyprYQOPqmXC/mL9uFNmGDCEwK6OauWl9z2 UzrVSUWF5vXHTzOgd4Au5ibJvfeOS+vKC2yOhiOQ= Date: Sat, 9 Feb 2019 16:14:08 +0000 From: Jonathan Cameron To: Rui Miguel Silva Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Shawn Guo , Rob Herring , Fabio Estevam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Afonso Bordado Subject: Re: [PATCH v2 0/5] iio: gyro: add fxas2100x driver Message-ID: <20190209161408.70563782@archlinux> In-Reply-To: <20190205174333.17672-1-rui.silva@linaro.org> References: <20190205174333.17672-1-rui.silva@linaro.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 5 Feb 2019 17:43:28 +0000 Rui Miguel Silva wrote: > Hi, > This series introduce a NXP fxas2100x family tri axis gyroscope driver [0] > It add a core implementaiton plus an i2c and spi. > > This device can be found in the warp7 board [1], where it was tested. Firstly no wild cards anywhere in the naming please, that includes the filenames. It goes wrong far too often when a new part comes up that matches the wild cards but has a totally different interface. Secondly, this is the second driver proposed for this part... Not sure what happened to the previous driver? +CC Afonso. https://lore.kernel.org/lkml/201809121715.5Babt1QC%25fengguang.wu@intel.com/T/ At least worth checking for any feature differences. I'll review this without checking back to that driver though. thanks, Jonathan > > --- > Cheers, > Rui > > v1->v2: > Peter Meerwal-Stadler: > - changed (c) to current year > - add regmap include file in .h > - fix comments s/cuttof/cutoff/ > - add more info in mutex comment > - check value in range_fs_from_value > - ret not checked in range_value_from_fs > - move mode to enum type > - remove line between value get and validation of value in all file > - pre-write, regmap_field_write, post_write refactoring > - check val2 and val == 0 in write raw > - check in_anglvel_scale: 7.8125? > - trigger_handler: 2 => sizeof(s16) > - check buffer size > - print %02% to output chip id > - remove !! as state is bool > - trigger probe return devm_iio_trigger_register > - remove error msg in case of devm_iio_device_register > Fabio Estebam: > - rename FXAS2100X to FXAS21002 > - change compatible nxp,fxas2100x to the exact support > - add VDD and VDDIO regulators in bindings and driver > > > [0]: https://www.nxp.com/docs/en/data-sheet/FXAS21002.pdf > [1]: https://www.element14.com/community/community/designcenter/single-board-computers/warp7/overview > > Rui Miguel Silva (5): > iio: gyro: add DT bindings to fxas21002 > iio: gyro: fxas2100x: add core driver for fxas2100x gyroscope > iio: gyro: fxas2100x: add i2c driver > iio: gyro: fxas2100x: add spi driver > ARM: dts: imx7s-warp: add fxas21002 gyroscope > > .../bindings/iio/gyroscope/fxas2100x.txt | 18 + > arch/arm/boot/dts/imx7s-warp.dts | 7 + > drivers/iio/gyro/Kconfig | 22 + > drivers/iio/gyro/Makefile | 3 + > drivers/iio/gyro/fxas2100x.h | 151 +++ > drivers/iio/gyro/fxas2100x_core.c | 931 ++++++++++++++++++ > drivers/iio/gyro/fxas2100x_i2c.c | 73 ++ > drivers/iio/gyro/fxas2100x_spi.c | 70 ++ > 8 files changed, 1275 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > create mode 100644 drivers/iio/gyro/fxas2100x.h > create mode 100644 drivers/iio/gyro/fxas2100x_core.c > create mode 100644 drivers/iio/gyro/fxas2100x_i2c.c > create mode 100644 drivers/iio/gyro/fxas2100x_spi.c >