From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A0B0C43381 for ; Sat, 9 Mar 2019 05:16:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65C80207E0 for ; Sat, 9 Mar 2019 05:16:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="qpPwEAP5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfCIFQI (ORCPT ); Sat, 9 Mar 2019 00:16:08 -0500 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:60552 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfCIFQI (ORCPT ); Sat, 9 Mar 2019 00:16:08 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id E26C2CB6 for ; Sat, 9 Mar 2019 05:16:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dpaDROpzpZOx for ; Fri, 8 Mar 2019 23:16:06 -0600 (CST) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id B07B4C69 for ; Fri, 8 Mar 2019 23:16:06 -0600 (CST) Received: by mail-io1-f70.google.com with SMTP id b14so13189424ioh.1 for ; Fri, 08 Mar 2019 21:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=RVQnwg/PYtBCBexaiykPWmElOOWGcv0g7rMf9iHb8VI=; b=qpPwEAP5EE9PkZsuh52KgNvt3IldLlkqlJVFgAeo7yWn4BMj/Q88CqSsNDPTUK6B1B 1BQVfwJGCiE0qN1ynQ2MiHCkdj4wfnT5NrpIWTKQ1RTx4b7gP/Xy5Kl12JyznTF66x6T YaShylg0UPS2qNep6mNUCddyJ0276SQ+4C1W6hBNsndVMYvSkRlv1IscR6TZJYqt28q2 axGRi+QpFWPxXTVAscBlBkqZQ3GLIWW/xkovy9tKTrN3ufIfb5VXRwGfXZTeYzvHV25G CuxFn1QCQK+OZOO8lbr/LFVJWy/padGO4uepQUJkGiUa3m2LxXj16gRqWUMuU9N0Bf/3 O7RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RVQnwg/PYtBCBexaiykPWmElOOWGcv0g7rMf9iHb8VI=; b=DQH22OAiUQ8LnDu9zSj65Vg9yNUg0eTe9YmixoLIVw4OOxi/mDm/qkW7PQLmVNKb5V oU2mCmWlh8OOXWKnphCq+VuJGrRikrLr++aPJqF69ZvDjD34J0FZsA16oZ11n+iRc0Ii Ags7S1N1i6wEom8jLE2puZON+D5k7sUnbiwqvmevqFxkThEplVXFOMOXgP+gal2KUm1u tmgH/RRTB08+6CPKl4UUmJC/FeiJ5QYrtuQwePcLn9I3E1sFGcWKvRKsWIXaV5JlTwbS LIJ2taZncL5PUZEuaOrC2aW2/rs7oTEnJXI7CC7taBJmyCmzSiQM1jvtTqhaIZRma2PI gDwQ== X-Gm-Message-State: APjAAAXxAR20OrvzgM7oPPnKmaT2DuZ36RsjWx5mmniYxMlVXjQvC2DA 2GazdtYip8Fwc4CVsuC3U43ufVnylo8Q8Xw0CqRKDa1awzDHzKFZYeQCQzZ9I0f6zUYn56lfY6e 1LJkhc3CcDimlIdINiQGPo6pX X-Received: by 2002:a02:c6a9:: with SMTP id o9mr12762534jan.70.1552108566290; Fri, 08 Mar 2019 21:16:06 -0800 (PST) X-Google-Smtp-Source: APXvYqwM/CZ/cXc3NfvPJDsxSmsGykVFf+S4qRMeccMYwDaVjuSW4/gLGjOh6/Iyh1Ywr/Qd9veaKA== X-Received: by 2002:a02:c6a9:: with SMTP id o9mr12762519jan.70.1552108566009; Fri, 08 Mar 2019 21:16:06 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id s10sm4180371ioc.21.2019.03.08.21.16.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 21:16:05 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: hmc: fix a potential NULL pointer dereference Date: Fri, 8 Mar 2019 23:15:32 -0600 Message-Id: <20190309051533.14309-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org devm_regmap_init_i2c may fail and return NULL. The fix returns the error when it fails. Signed-off-by: Kangjie Lu --- drivers/iio/magnetometer/hmc5843_i2c.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/magnetometer/hmc5843_i2c.c b/drivers/iio/magnetometer/hmc5843_i2c.c index 3de7f4426ac4..c0cd0823f8d5 100644 --- a/drivers/iio/magnetometer/hmc5843_i2c.c +++ b/drivers/iio/magnetometer/hmc5843_i2c.c @@ -58,8 +58,13 @@ static const struct regmap_config hmc5843_i2c_regmap_config = { static int hmc5843_i2c_probe(struct i2c_client *cli, const struct i2c_device_id *id) { + struct regmap *devm_regmap = devm_regmap_init_i2c(cli, + &hmc5843_i2c_regmap_config); + if (IS_ERR(devm_regmap)) + return PTR_ERR(devm_regmap); + return hmc5843_common_probe(&cli->dev, - devm_regmap_init_i2c(cli, &hmc5843_i2c_regmap_config), + devm_regmap, id->driver_data, id->name); } -- 2.17.1