From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C9FC43381 for ; Sat, 16 Mar 2019 15:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12273218E0 for ; Sat, 16 Mar 2019 15:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552751369; bh=zyiMt94slNDL609O6muiFMuaVvrUYx6UStlu7Ga8z0E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=V4tS8dC1zBi3HZZypTWMW2Yl3PqAVuXWaTEkDbxJoUmuA0eWLSFyLpm0Qo7+oD9wp H5dWjHEeNHEaOjeDktyw57SvgkcOiDuKKhlINeXDkCBR/KX+hMdm45dRzG9TAIr9y7 XKsn2o22dzyaC53KxNPDb/k42gqbjWFxqzCMct1o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbfCPPt2 (ORCPT ); Sat, 16 Mar 2019 11:49:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726376AbfCPPt2 (ORCPT ); Sat, 16 Mar 2019 11:49:28 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F40B2064C; Sat, 16 Mar 2019 15:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552751367; bh=zyiMt94slNDL609O6muiFMuaVvrUYx6UStlu7Ga8z0E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1QfFM4BDG8qVRN3KqHNDSaf4x/bJIRmJevysHH1gynCrrPdU2lqhnytu15oULcL8d iTnsV/4PF5G9DYLQdzs2ruEg+yGB3gHdaj9PIM/6aaLysK+d1MaMWL8z/jAcnsaI91 KYuyJAQCfpjpqCCcc4V+ll3t6gNNgzX870JJ6/Xc= Date: Sat, 16 Mar 2019 15:49:21 +0000 From: Jonathan Cameron To: Sven Van Asbroeck Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Manish Narani , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] iio: adc: xilinx: fix potential use-after-free on probe Message-ID: <20190316154921.1745de59@archlinux> In-Reply-To: <20190310185826.25916-2-TheSven73@gmail.com> References: <20190310185826.25916-1-TheSven73@gmail.com> <20190310185826.25916-2-TheSven73@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 10 Mar 2019 14:58:25 -0400 Sven Van Asbroeck wrote: > If probe errors out after request_irq(), its error path > does not explicitly cancel the delayed work, which may > have been scheduled by the interrupt handler. > > This means the delayed work may still be running when > the core frees the private structure (struct xadc). > This is a potential use-after-free. > > Fix by inserting cancel_delayed_work_sync() in the probe > error path. > > Signed-off-by: Sven Van Asbroeck Again, seems fine to me. Applied to the fixes-togreg branch of iio.git. thanks, Jonathan > --- > drivers/iio/adc/xilinx-xadc-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c > index 1960694e8007..15e1a103f37d 100644 > --- a/drivers/iio/adc/xilinx-xadc-core.c > +++ b/drivers/iio/adc/xilinx-xadc-core.c > @@ -1290,6 +1290,7 @@ static int xadc_probe(struct platform_device *pdev) > > err_free_irq: > free_irq(xadc->irq, indio_dev); > + cancel_delayed_work_sync(&xadc->zynq_unmask_work); > err_clk_disable_unprepare: > clk_disable_unprepare(xadc->clk); > err_free_samplerate_trigger: