From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5CA5C43381 for ; Sat, 16 Mar 2019 18:43:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 934EE218D4 for ; Sat, 16 Mar 2019 18:43:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HmlCxQ4g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbfCPSnU (ORCPT ); Sat, 16 Mar 2019 14:43:20 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:38584 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbfCPSnT (ORCPT ); Sat, 16 Mar 2019 14:43:19 -0400 Received: by mail-qt1-f196.google.com with SMTP id s1so13764821qte.5; Sat, 16 Mar 2019 11:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jNwUfMd3kcWX7rL6UO2R3uW4ypSSBtyq53oqxv6hGi8=; b=HmlCxQ4gFwvDtLNsNMGDYapevsEJOZFaLIUzWV8PYQVNdBL42ac9TJPzw8w2F/d+/G FrWgwlovgGkgPHjC1Sl568E+tLl1O4CRy35P7JnPtnexXym1l3vAUauLoGmnNeAPvUoc 3qN5KrLkvBxxIRsNqwET6nKeR/owJjxDOefmmeZPu2+ij+ui/3L0VRrmPoLz0EU/F2BI xmtY0Mfy8XNbivSr37nckNAEqATxAzQboH8vkeEAIz6YnIuIYqjObyqmW7XQo8oNdeyk sa3+d/fgddF7o+Jr8wgtKoxrWxIhtqBT1WXiKyfJglVj5TcnWpt8snwjPNQ/uqsADSF9 gw4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jNwUfMd3kcWX7rL6UO2R3uW4ypSSBtyq53oqxv6hGi8=; b=jqAC7KhaxKDjOQB4azuGazlB3I0k1P14VB12tGJueAkRlx7A54OhOWWQaoedLBfo3g 1e3y40hhTOba9zAsX2uvKJ7ONSGGj9oz/MtySyjhnZhAX/Q3RLsjVWAkJa8Up+HYW+ye QYycpz+iT3u5rUb4F33Raq+bU5K0450VLmi4xjInzFbSuf7O9ewxwNchQ/lVX/NPmGJD lsjldPR81tppYTOZ9JPTWoyho7BWaaoPgxlKKx7UqJX/BC14ycVWS9ziMzUF/Dza5gOe mvlCnEquYKfBMdZx/RElMG09wBVMLb9Q3neXwQxLkB7Lrx9t7lUDMEJ72ciTHwMFTlU0 Xdtw== X-Gm-Message-State: APjAAAVEq0isw2uBjtDL9jCaStSwMPBqqZm+G5FkN0lS/T66FDBSLDbx 1sphiIpdNEBqh2+bWzXRIcw= X-Google-Smtp-Source: APXvYqwecRoHFkrthbW76SBEVaw2xARCLPGKcS98FTQQYFj9nTMPAhEq8ntKRJ2NmXtbMIpAcOzhjA== X-Received: by 2002:a0c:b993:: with SMTP id v19mr7170675qvf.93.1552761797872; Sat, 16 Mar 2019 11:43:17 -0700 (PDT) Received: from renatolg ([186.220.0.66]) by smtp.gmail.com with ESMTPSA id t1sm3005030qtp.88.2019.03.16.11.43.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Mar 2019 11:43:17 -0700 (PDT) From: Renato Lui Geh X-Google-Original-From: Renato Lui Geh Date: Sat, 16 Mar 2019 15:43:11 -0300 To: Jonathan Cameron Cc: Renato Lui Geh , lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, stefan.popa@analog.com, alexandru.Ardelean@analog.com, giuliano.belinassi@usp.br, robh+dt@kernel.org, mark.rutland@arm.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, devicetree@vger.kernel.org Subject: Re: [PATCH v5 10/11] staging: iio: ad7780: moving ad7780 out of staging Message-ID: <20190316184311.h3liyw2tjufbv7db@renatolg> References: <20190316181942.618b0a80@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20190316181942.618b0a80@archlinux> User-Agent: NeoMutt/20180716 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 03/16, Jonathan Cameron wrote: >On Fri, 15 Mar 2019 23:15:55 -0300 >Renato Lui Geh wrote: > >> Move ad7780 ADC driver out of staging and into the mainline. >> >> The ad7780 is a sigma-delta analog to digital converter. This driver provides >> reading voltage values and status bits from both the ad778x and ad717x series. >> Its interface also allows writing on the FILTER and GAIN GPIO pins on the >> ad778x. >> >> Signed-off-by: Renato Lui Geh >> Signed-off-by: Giuliano Belinassi >> Co-developed-by: Giuliano Belinassi > >Applied to the togreg branch of iio.git and pushed out as testing. >Note I won't be pushing that out as non rebasing (togreg) until at >least next weekend, so there is a bit of time for any last minute >feedback etc. > >Thanks for all your hard work on this and great to see it graduate from >staging! Huge thanks to both you and Alexandru for all the great feedback and help on this! Hope to continue to send many more contributions here. :) > >Thanks, > >Jonathan > >> --- >> Changes in v3: >> - Changes unrelated to moving the driver to main tree were resent as >> individual patches >> Changes in v4: >> - Removed line warning it was safe to build the ad7780 driver by >> default >> >> drivers/iio/adc/Kconfig | 12 + >> drivers/iio/adc/Makefile | 1 + >> drivers/iio/adc/ad7780.c | 376 +++++++++++++++++++++++++++++++ >> drivers/staging/iio/adc/Kconfig | 13 -- >> drivers/staging/iio/adc/Makefile | 1 - >> drivers/staging/iio/adc/ad7780.c | 376 ------------------------------- >> 6 files changed, 389 insertions(+), 390 deletions(-) >> create mode 100644 drivers/iio/adc/ad7780.c >> delete mode 100644 drivers/staging/iio/adc/ad7780.c >> >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig >> index f3cc7a31bce5..6b36a45bd09f 100644 >> --- a/drivers/iio/adc/Kconfig >> +++ b/drivers/iio/adc/Kconfig >> @@ -108,6 +108,18 @@ config AD7766 >> To compile this driver as a module, choose M here: the module will be >> called ad7766. >> >> +config AD7780 >> + tristate "Analog Devices AD7780 and similar ADCs driver" >> + depends on SPI >> + depends on GPIOLIB || COMPILE_TEST >> + select AD_SIGMA_DELTA >> + help >> + Say yes here to build support for Analog Devices AD7170, AD7171, >> + AD7780 and AD7781 SPI analog to digital converters (ADC). >> + >> + To compile this driver as a module, choose M here: the >> + module will be called ad7780. >> + >> config AD7791 >> tristate "Analog Devices AD7791 ADC driver" >> depends on SPI >> diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile >> index ea5031348052..b48852157115 100644 >> --- a/drivers/iio/adc/Makefile >> +++ b/drivers/iio/adc/Makefile >> @@ -15,6 +15,7 @@ obj-$(CONFIG_AD7606_IFACE_PARALLEL) += ad7606_par.o >> obj-$(CONFIG_AD7606_IFACE_SPI) += ad7606_spi.o >> obj-$(CONFIG_AD7606) += ad7606.o >> obj-$(CONFIG_AD7766) += ad7766.o >> +obj-$(CONFIG_AD7780) += ad7780.o >> obj-$(CONFIG_AD7791) += ad7791.o >> obj-$(CONFIG_AD7793) += ad7793.o >> obj-$(CONFIG_AD7887) += ad7887.o >> diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c >> new file mode 100644 >> index 000000000000..23b731a92e32 >> --- /dev/null >> +++ b/drivers/iio/adc/ad7780.c >> @@ -0,0 +1,376 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * AD7170/AD7171 and AD7780/AD7781 SPI ADC driver >> + * >> + * Copyright 2011 Analog Devices Inc. >> + * Copyright 2019 Renato Lui Geh >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> + >> +#define AD7780_RDY BIT(7) >> +#define AD7780_FILTER BIT(6) >> +#define AD7780_ERR BIT(5) >> +#define AD7780_ID1 BIT(4) >> +#define AD7780_ID0 BIT(3) >> +#define AD7780_GAIN BIT(2) >> + >> +#define AD7170_ID 0 >> +#define AD7171_ID 1 >> +#define AD7780_ID 1 >> +#define AD7781_ID 0 >> + >> +#define AD7780_ID_MASK (AD7780_ID0 | AD7780_ID1) >> + >> +#define AD7780_PATTERN_GOOD 1 >> +#define AD7780_PATTERN_MASK GENMASK(1, 0) >> + >> +#define AD7170_PATTERN_GOOD 5 >> +#define AD7170_PATTERN_MASK GENMASK(2, 0) >> + >> +#define AD7780_GAIN_MIDPOINT 64 >> +#define AD7780_FILTER_MIDPOINT 13350 >> + >> +static const unsigned int ad778x_gain[2] = { 1, 128 }; >> +static const unsigned int ad778x_odr_avail[2] = { 10000, 16700 }; >> + >> +struct ad7780_chip_info { >> + struct iio_chan_spec channel; >> + unsigned int pattern_mask; >> + unsigned int pattern; >> + bool is_ad778x; >> +}; >> + >> +struct ad7780_state { >> + const struct ad7780_chip_info *chip_info; >> + struct regulator *reg; >> + struct gpio_desc *powerdown_gpio; >> + struct gpio_desc *gain_gpio; >> + struct gpio_desc *filter_gpio; >> + unsigned int gain; >> + unsigned int odr; >> + unsigned int int_vref_mv; >> + >> + struct ad_sigma_delta sd; >> +}; >> + >> +enum ad7780_supported_device_ids { >> + ID_AD7170, >> + ID_AD7171, >> + ID_AD7780, >> + ID_AD7781, >> +}; >> + >> +static struct ad7780_state *ad_sigma_delta_to_ad7780(struct ad_sigma_delta *sd) >> +{ >> + return container_of(sd, struct ad7780_state, sd); >> +} >> + >> +static int ad7780_set_mode(struct ad_sigma_delta *sigma_delta, >> + enum ad_sigma_delta_mode mode) >> +{ >> + struct ad7780_state *st = ad_sigma_delta_to_ad7780(sigma_delta); >> + unsigned int val; >> + >> + switch (mode) { >> + case AD_SD_MODE_SINGLE: >> + case AD_SD_MODE_CONTINUOUS: >> + val = 1; >> + break; >> + default: >> + val = 0; >> + break; >> + } >> + >> + gpiod_set_value(st->powerdown_gpio, val); >> + >> + return 0; >> +} >> + >> +static int ad7780_read_raw(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + int *val, >> + int *val2, >> + long m) >> +{ >> + struct ad7780_state *st = iio_priv(indio_dev); >> + int voltage_uv; >> + >> + switch (m) { >> + case IIO_CHAN_INFO_RAW: >> + return ad_sigma_delta_single_conversion(indio_dev, chan, val); >> + case IIO_CHAN_INFO_SCALE: >> + voltage_uv = regulator_get_voltage(st->reg); >> + if (voltage_uv < 0) >> + return voltage_uv; >> + voltage_uv /= 1000; >> + *val = voltage_uv * st->gain; >> + *val2 = chan->scan_type.realbits - 1; >> + st->int_vref_mv = voltage_uv; >> + return IIO_VAL_FRACTIONAL_LOG2; >> + case IIO_CHAN_INFO_OFFSET: >> + *val = -(1 << (chan->scan_type.realbits - 1)); >> + return IIO_VAL_INT; >> + case IIO_CHAN_INFO_SAMP_FREQ: >> + *val = st->odr; >> + return IIO_VAL_INT; >> + default: >> + break; >> + } >> + >> + return -EINVAL; >> +} >> + >> +static int ad7780_write_raw(struct iio_dev *indio_dev, >> + struct iio_chan_spec const *chan, >> + int val, >> + int val2, >> + long m) >> +{ >> + struct ad7780_state *st = iio_priv(indio_dev); >> + const struct ad7780_chip_info *chip_info = st->chip_info; >> + unsigned long long vref; >> + unsigned int full_scale, gain; >> + >> + if (!chip_info->is_ad778x) >> + return -EINVAL; >> + >> + switch (m) { >> + case IIO_CHAN_INFO_SCALE: >> + if (val != 0) >> + return -EINVAL; >> + >> + vref = st->int_vref_mv * 1000000LL; >> + full_scale = 1 << (chip_info->channel.scan_type.realbits - 1); >> + gain = DIV_ROUND_CLOSEST(vref, full_scale); >> + gain = DIV_ROUND_CLOSEST(gain, val2); >> + st->gain = gain; >> + if (gain < AD7780_GAIN_MIDPOINT) >> + gain = 0; >> + else >> + gain = 1; >> + gpiod_set_value(st->gain_gpio, gain); >> + break; >> + case IIO_CHAN_INFO_SAMP_FREQ: >> + if (1000*val + val2/1000 < AD7780_FILTER_MIDPOINT) >> + val = 0; >> + else >> + val = 1; >> + st->odr = ad778x_odr_avail[val]; >> + gpiod_set_value(st->filter_gpio, val); >> + break; >> + default: >> + break; >> + } >> + >> + return 0; >> +} >> + >> +static int ad7780_postprocess_sample(struct ad_sigma_delta *sigma_delta, >> + unsigned int raw_sample) >> +{ >> + struct ad7780_state *st = ad_sigma_delta_to_ad7780(sigma_delta); >> + const struct ad7780_chip_info *chip_info = st->chip_info; >> + >> + if ((raw_sample & AD7780_ERR) || >> + ((raw_sample & chip_info->pattern_mask) != chip_info->pattern)) >> + return -EIO; >> + >> + if (chip_info->is_ad778x) { >> + st->gain = ad778x_gain[raw_sample & AD7780_GAIN]; >> + st->odr = ad778x_odr_avail[raw_sample & AD7780_FILTER]; >> + } >> + >> + return 0; >> +} >> + >> +static const struct ad_sigma_delta_info ad7780_sigma_delta_info = { >> + .set_mode = ad7780_set_mode, >> + .postprocess_sample = ad7780_postprocess_sample, >> + .has_registers = false, >> +}; >> + >> +#define AD7780_CHANNEL(bits, wordsize) \ >> + AD_SD_CHANNEL(1, 0, 0, bits, 32, wordsize - bits) >> +#define AD7170_CHANNEL(bits, wordsize) \ >> + AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, wordsize - bits) >> + >> +static const struct ad7780_chip_info ad7780_chip_info_tbl[] = { >> + [ID_AD7170] = { >> + .channel = AD7170_CHANNEL(12, 24), >> + .pattern = AD7170_PATTERN_GOOD, >> + .pattern_mask = AD7170_PATTERN_MASK, >> + .is_ad778x = false, >> + }, >> + [ID_AD7171] = { >> + .channel = AD7170_CHANNEL(16, 24), >> + .pattern = AD7170_PATTERN_GOOD, >> + .pattern_mask = AD7170_PATTERN_MASK, >> + .is_ad778x = false, >> + }, >> + [ID_AD7780] = { >> + .channel = AD7780_CHANNEL(24, 32), >> + .pattern = AD7780_PATTERN_GOOD, >> + .pattern_mask = AD7780_PATTERN_MASK, >> + .is_ad778x = true, >> + }, >> + [ID_AD7781] = { >> + .channel = AD7780_CHANNEL(20, 32), >> + .pattern = AD7780_PATTERN_GOOD, >> + .pattern_mask = AD7780_PATTERN_MASK, >> + .is_ad778x = true, >> + }, >> +}; >> + >> +static const struct iio_info ad7780_info = { >> + .read_raw = ad7780_read_raw, >> + .write_raw = ad7780_write_raw, >> +}; >> + >> +static int ad7780_init_gpios(struct device *dev, struct ad7780_state *st) >> +{ >> + int ret; >> + >> + st->powerdown_gpio = devm_gpiod_get_optional(dev, >> + "powerdown", >> + GPIOD_OUT_LOW); >> + if (IS_ERR(st->powerdown_gpio)) { >> + ret = PTR_ERR(st->powerdown_gpio); >> + dev_err(dev, "Failed to request powerdown GPIO: %d\n", ret); >> + return ret; >> + } >> + >> + if (!st->chip_info->is_ad778x) >> + return 0; >> + >> + >> + st->gain_gpio = devm_gpiod_get_optional(dev, >> + "adi,gain", >> + GPIOD_OUT_HIGH); >> + if (IS_ERR(st->gain_gpio)) { >> + ret = PTR_ERR(st->gain_gpio); >> + dev_err(dev, "Failed to request gain GPIO: %d\n", ret); >> + return ret; >> + } >> + >> + st->filter_gpio = devm_gpiod_get_optional(dev, >> + "adi,filter", >> + GPIOD_OUT_HIGH); >> + if (IS_ERR(st->filter_gpio)) { >> + ret = PTR_ERR(st->filter_gpio); >> + dev_err(dev, "Failed to request filter GPIO: %d\n", ret); >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static int ad7780_probe(struct spi_device *spi) >> +{ >> + struct ad7780_state *st; >> + struct iio_dev *indio_dev; >> + int ret; >> + >> + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); >> + if (!indio_dev) >> + return -ENOMEM; >> + >> + st = iio_priv(indio_dev); >> + st->gain = 1; >> + >> + ad_sd_init(&st->sd, indio_dev, spi, &ad7780_sigma_delta_info); >> + >> + st->chip_info = >> + &ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data]; >> + >> + spi_set_drvdata(spi, indio_dev); >> + >> + indio_dev->dev.parent = &spi->dev; >> + indio_dev->name = spi_get_device_id(spi)->name; >> + indio_dev->modes = INDIO_DIRECT_MODE; >> + indio_dev->channels = &st->chip_info->channel; >> + indio_dev->num_channels = 1; >> + indio_dev->info = &ad7780_info; >> + >> + ret = ad7780_init_gpios(&spi->dev, st); >> + if (ret) >> + goto error_cleanup_buffer_and_trigger; >> + >> + st->reg = devm_regulator_get(&spi->dev, "avdd"); >> + if (IS_ERR(st->reg)) >> + return PTR_ERR(st->reg); >> + >> + ret = regulator_enable(st->reg); >> + if (ret) { >> + dev_err(&spi->dev, "Failed to enable specified AVdd supply\n"); >> + return ret; >> + } >> + >> + ret = ad_sd_setup_buffer_and_trigger(indio_dev); >> + if (ret) >> + goto error_disable_reg; >> + >> + ret = iio_device_register(indio_dev); >> + if (ret) >> + goto error_cleanup_buffer_and_trigger; >> + >> + return 0; >> + >> +error_cleanup_buffer_and_trigger: >> + ad_sd_cleanup_buffer_and_trigger(indio_dev); >> +error_disable_reg: >> + regulator_disable(st->reg); >> + >> + return ret; >> +} >> + >> +static int ad7780_remove(struct spi_device *spi) >> +{ >> + struct iio_dev *indio_dev = spi_get_drvdata(spi); >> + struct ad7780_state *st = iio_priv(indio_dev); >> + >> + iio_device_unregister(indio_dev); >> + ad_sd_cleanup_buffer_and_trigger(indio_dev); >> + >> + regulator_disable(st->reg); >> + >> + return 0; >> +} >> + >> +static const struct spi_device_id ad7780_id[] = { >> + {"ad7170", ID_AD7170}, >> + {"ad7171", ID_AD7171}, >> + {"ad7780", ID_AD7780}, >> + {"ad7781", ID_AD7781}, >> + {} >> +}; >> +MODULE_DEVICE_TABLE(spi, ad7780_id); >> + >> +static struct spi_driver ad7780_driver = { >> + .driver = { >> + .name = "ad7780", >> + }, >> + .probe = ad7780_probe, >> + .remove = ad7780_remove, >> + .id_table = ad7780_id, >> +}; >> +module_spi_driver(ad7780_driver); >> + >> +MODULE_AUTHOR("Michael Hennerich "); >> +MODULE_DESCRIPTION("Analog Devices AD7780 and similar ADCs"); >> +MODULE_LICENSE("GPL v2"); > >