From: Sean Nyekjaer <sean@geanix.com>
To: linux-iio@vger.kernel.org, jic23@kernel.org
Cc: Sean Nyekjaer <sean@geanix.com>
Subject: [PATCH 1/2] iio: adc: ti-ads8688: save values correct in buffer
Date: Tue, 7 May 2019 10:23:03 +0200 [thread overview]
Message-ID: <20190507082304.11692-1-sean@geanix.com> (raw)
Fill the read values in the buffer so we comply
with the given index values.
Fixes: 2a86487786b5c ("iio: adc: ti-ads8688: add trigger and buffer support")
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
drivers/iio/adc/ti-ads8688.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
index f9461070a74a..d9c354dbd7e4 100644
--- a/drivers/iio/adc/ti-ads8688.c
+++ b/drivers/iio/adc/ti-ads8688.c
@@ -387,13 +387,12 @@ static irqreturn_t ads8688_trigger_handler(int irq, void *p)
struct iio_poll_func *pf = p;
struct iio_dev *indio_dev = pf->indio_dev;
u16 buffer[ADS8688_MAX_CHANNELS + sizeof(s64)/sizeof(u16)];
- int i, j = 0;
+ int bit;
- for (i = 0; i < indio_dev->masklength; i++) {
- if (!test_bit(i, indio_dev->active_scan_mask))
- continue;
- buffer[j] = ads8688_read(indio_dev, i);
- j++;
+ memset(buffer, 0, sizeof(buffer));
+
+ for_each_set_bit(bit, indio_dev->active_scan_mask, indio_dev->masklength) {
+ buffer[bit] = ads8688_read(indio_dev, bit);
}
iio_push_to_buffers_with_timestamp(indio_dev, buffer,
--
2.21.0
next reply other threads:[~2019-05-07 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 8:23 Sean Nyekjaer [this message]
2019-05-07 8:23 ` [PATCH 2/2] iio: adc: ti-ads8688: fix timestamp is not updated in buffer Sean Nyekjaer
2019-05-11 11:50 ` Jonathan Cameron
2019-05-11 11:44 ` [PATCH 1/2] iio: adc: ti-ads8688: save values correct " Jonathan Cameron
2019-05-11 12:03 ` Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507082304.11692-1-sean@geanix.com \
--to=sean@geanix.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).