linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ruslan Babayev <ruslan@babayev.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	xe-linux-external@cisco.com, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification
Date: Sat, 11 May 2019 12:49:05 +0100	[thread overview]
Message-ID: <20190511124905.11d24e5b@archlinux> (raw)
In-Reply-To: <20190505192438.2644-2-ruslan@babayev.com>

On Sun,  5 May 2019 12:24:37 -0700
Ruslan Babayev <ruslan@babayev.com> wrote:

> The ds4424_get_value function takes channel number as it's 3rd
> argument and translates it internally into I2C address using
> DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
> already translated I2C address as its last argument.
> 
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ds4424.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 2b3ba1a66fe8..ae9be792693b 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
>  {
>  	int ret, val;
>  
> -	ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
> +	ret = ds4424_get_value(indio_dev, &val, 0);
>  	if (ret < 0)
>  		dev_err(&indio_dev->dev,
>  				"%s failed. ret: %d\n", __func__, ret);


      reply	other threads:[~2019-05-11 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 19:24 [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification Ruslan Babayev
2019-05-11 11:49 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190511124905.11d24e5b@archlinux \
    --to=jic23@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=ruslan@babayev.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).