From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC77C04AAF for ; Sat, 18 May 2019 09:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E7A120848 for ; Sat, 18 May 2019 09:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558170480; bh=wXFh7i79M3gDBIl6uydPBZ9mair/rwIE8lvUbTn1Kmk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Cgwb5b0UU29k2o/T77s3o179xIKU0ySqJFgIf18jQQPW1C/3xDUcvRO6LRXfE9U62 7pA22YhQjqgxafqK7NEjCRvhumFRGkFuZF3HTW2l2e1NXRPKDgbbz0JqE1r27vFv3o ZrDI7HU/jtFkoFwYDD1sjKo0jRJ9sWkG+ZPeEuN0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729674AbfERJH7 (ORCPT ); Sat, 18 May 2019 05:07:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729334AbfERJH7 (ORCPT ); Sat, 18 May 2019 05:07:59 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94D7D2082C; Sat, 18 May 2019 09:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558170479; bh=wXFh7i79M3gDBIl6uydPBZ9mair/rwIE8lvUbTn1Kmk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NOf3VfUVgiBk4liAwfnapnqBvCJDl2bE49zuK6ynKIQ45D+hBp31B4Nqc40TlMTA2 9UhrIkCBexNi//K4t4Vcwp1cc8aWlhuQml3HrMNRfaUMaVgUFuvSluzVpYJMzwTqEl +srOqxLXm/+LHwCorYQRTlEIHEzm/NcCMB40SDlc= Date: Sat, 18 May 2019 10:07:53 +0100 From: Jonathan Cameron To: Rob Herring Cc: Adam Michaelis , linux-iio@vger.kernel.org, lars@metafoo.de, michael.hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, charles-antoine.couret@essensium.com, devicetree@vger.kernel.org, brandon.maier@rockwellcollins.com, clayton.shotwell@rockwellcollins.com Subject: Re: [PATCH v3 3/5] dt-bindings: iio: ad7949: Add adi,reference-select Message-ID: <20190518100753.39b438cb@archlinux> In-Reply-To: <20190514182311.GA31516@bogus> References: <1557759185-167857-1-git-send-email-adam.michaelis@rockwellcollins.com> <1557759185-167857-3-git-send-email-adam.michaelis@rockwellcollins.com> <20190514182311.GA31516@bogus> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 14 May 2019 13:23:11 -0500 Rob Herring wrote: > On Mon, 13 May 2019 09:53:03 -0500, Adam Michaelis wrote: > > Adding optional parameter to AD7949 to specify the source for the > > reference voltage signal. Default value is maintained with option '3' to > > match previous version of driver. > > > > Signed-off-by: Adam Michaelis > > --- > > V2: > > - Add some defines to reduce use of magic numbers. > > V3: > > - Re-think usage of device tree parameter to focus on the > > actual reference sources instead of the raw hardware > > configuration. > > --- > > .../devicetree/bindings/iio/adc/ad7949.txt | 21 +++++++++++++++++++-- > > 1 file changed, 19 insertions(+), 2 deletions(-) > > > > Reviewed-by: Rob Herring Looks fine to me as well. Analog review awaited before applying. For reference Acked-by: Jonathan Cameron