From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4314AC04AAF for ; Sat, 18 May 2019 10:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 171FE20B7C for ; Sat, 18 May 2019 10:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558175085; bh=ibvW7SwyQ3CtG0/rGvBYo/iCT1Uk227T0d/UHdaBThQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2PGBwTqdEW4zj+EcaoEmm+vnY93gbD9RJymNmYRxbk0Zx0f8wtU9uPglZjp77QgAY MRtZlbleAdk7Z/QHyLq26pI2JWI82GkbnZgbX+DCILHJy+wO1qufmOmhfmxW06UqNQ RdFa4QoQPu6n2UG1CvOksshGhP9WWiQEnwcgGDIE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725950AbfERKYo (ORCPT ); Sat, 18 May 2019 06:24:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:40152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729489AbfERKYo (ORCPT ); Sat, 18 May 2019 06:24:44 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3054D2087E; Sat, 18 May 2019 10:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558175083; bh=ibvW7SwyQ3CtG0/rGvBYo/iCT1Uk227T0d/UHdaBThQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oXbas6dlXC+mwnFsb8eD64SpoU/zr0mteOpjUPoZJs2BnIldcs30PSe+KBUpm3gTp jsmYkIE8pBR8SMQAG+O1Y59CNL0hp0pv8piqJthfoN0R4aPbnRT4BCAA15CqPdZhbc gHs/UeC7QMEbBTAfZlVFDIn3DNjUX9m2XjK+XUQo= Date: Sat, 18 May 2019 11:24:37 +0100 From: Jonathan Cameron To: Beniamin Bia Cc: , , , , , , , , , , , Subject: Re: [PATCH 5/5] iio: adc: ad7606: Add debug mode for ad7616 Message-ID: <20190518112437.0ec3d0e8@archlinux> In-Reply-To: <20190516143208.19294-5-beniamin.bia@analog.com> References: <20190516143208.19294-1-beniamin.bia@analog.com> <20190516143208.19294-5-beniamin.bia@analog.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 16 May 2019 17:32:08 +0300 Beniamin Bia wrote: > Support for register access was added for spi devices. > > Signed-off-by: Beniamin Bia Looks fine. For my reference please add Acked-by: Jonathan Cameron > --- > drivers/iio/adc/ad7606.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c > index f77df3efe43f..b03bdce4fd4e 100644 > --- a/drivers/iio/adc/ad7606.c > +++ b/drivers/iio/adc/ad7606.c > @@ -134,6 +134,30 @@ static int ad7606_spi_write_mask(struct ad7606_state *st, > return ad7606_spi_reg_write(st, addr, readval); > } > > +static int ad7606_reg_access(struct iio_dev *indio_dev, > + unsigned int reg, > + unsigned int writeval, > + unsigned int *readval) > +{ > + struct ad7606_state *st = iio_priv(indio_dev); > + int ret; > + > + mutex_lock(&st->lock); > + if (readval) { > + ret = ad7606_spi_reg_read(st, reg); > + if (ret < 0) > + goto err_unlock; > + *readval = ret; > + ret = 0; > + } else { > + ret = ad7606_spi_reg_write(st, reg, writeval); > + } > +err_unlock: > + mutex_unlock(&st->lock); > + > + return ret; > +} > + > static int ad7606_read_samples(struct ad7606_state *st) > { > unsigned int num = st->chip_info->num_channels; > @@ -645,6 +669,7 @@ static const struct iio_info ad7606_info_no_os_or_range = { > static const struct iio_info ad7606_info_os_and_range = { > .read_raw = &ad7606_read_raw, > .write_raw = &ad7606_write_raw, > + .debugfs_reg_access = &ad7606_reg_access, > .attrs = &ad7606_attribute_group_os_and_range, > .validate_trigger = &ad7606_validate_trigger, > };