From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA3CC04AAF for ; Sat, 18 May 2019 10:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D515A20B7C for ; Sat, 18 May 2019 10:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558175734; bh=rguySsEOq+x1PGhSAfvkomBO3m+7PPVtFbTny4CxQvk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=h3c4Sy5rZHgjV8Mgpx+MdOSA3jnJ6X+chg2lOELH6E8A2orOBiMkH085E2BokUBWq uRVSS+RXjjM0XVmAMt52R7wU97FPc5QUY1kkUzkHV8wC2/rQTqtyTffParaDxTGLtp UXLVanwyyc/oX4UhP40Sn88rP4alBsAq1IO4YdLE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729127AbfERKfe (ORCPT ); Sat, 18 May 2019 06:35:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbfERKfe (ORCPT ); Sat, 18 May 2019 06:35:34 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A4782087E; Sat, 18 May 2019 10:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558175733; bh=rguySsEOq+x1PGhSAfvkomBO3m+7PPVtFbTny4CxQvk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cOVT/saTJsx+a5tobw3SyYPMSJhf//2/uGEpTPTOKcllnYJ6Yf5yMDiz7P38DgrXa Bm/lQx8yBCEvwrau2ItFfNCPKUsy1Mzc2qyOmjzBeIOEgvUXYi9stJX2Mxb5FPd4ob XgeKGurk1c+phpe1Ph98kgE8CNRTJaaERC3L6CFE= Date: Sat, 18 May 2019 11:35:27 +0100 From: Jonathan Cameron To: Chun-Hung Wu Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , , , , Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support Message-ID: <20190518113527.5210b0bf@archlinux> In-Reply-To: <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 16 May 2019 16:10:46 +0800 Chun-Hung Wu wrote: > Move suspend/resume to late_suspend and > early_resume to gurantee users can use auxadc guarantee > driver at suspend/resume stage. No problem with the patch content, but we need a reason why they may want to do so? Thanks, Jonathan > > Signed-off-by: Chun-Hung Wu > --- > drivers/iio/adc/mt6577_auxadc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index e1bdcc0..58d7cb2 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops, > - mt6577_auxadc_suspend, > - mt6577_auxadc_resume); > +static const struct dev_pm_ops mt6577_auxadc_pm_ops = { > + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend, > + mt6577_auxadc_resume) > +}; > > static const struct of_device_id mt6577_auxadc_of_match[] = { > { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat},