* [RESEND PATCH] staging: iio: adt7316: create of_device_id array
@ 2019-05-18 22:43 Bárbara Fernandes
2019-05-19 10:44 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Bárbara Fernandes @ 2019-05-18 22:43 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman
Cc: linux-iio, devel, linux-kernel, Bárbara Fernandes, Wilson Sales
Create structure of type of_device_id in order to register all devices
the driver is able to manage.
Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Wilson Sales <spoonm@spoonm.org>
Co-developed-by: Wilson Sales <spoonm@spoonm.org>
---
drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
index 8294b9c1e3c2..9968775f1d23 100644
--- a/drivers/staging/iio/addac/adt7316-spi.c
+++ b/drivers/staging/iio/addac/adt7316-spi.c
@@ -127,9 +127,22 @@ static const struct spi_device_id adt7316_spi_id[] = {
MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
+static const struct of_device_id adt7316_of_spi_match[] = {
+ { .compatible = "adi,adt7316" },
+ { .compatible = "adi,adt7317" },
+ { .compatible = "adi,adt7318" },
+ { .compatible = "adi,adt7516" },
+ { .compatible = "adi,adt7517" },
+ { .compatible = "adi,adt7519" },
+ { }
+};
+
+MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
+
static struct spi_driver adt7316_driver = {
.driver = {
.name = "adt7316",
+ .of_match_table = adt7316_of_spi_match,
.pm = ADT7316_PM_OPS,
},
.probe = adt7316_spi_probe,
--
2.22.0.rc0.1.g337bb99195.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] staging: iio: adt7316: create of_device_id array
2019-05-18 22:43 [RESEND PATCH] staging: iio: adt7316: create of_device_id array Bárbara Fernandes
@ 2019-05-19 10:44 ` Jonathan Cameron
2019-05-20 9:36 ` Alexandru Ardelean
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-05-19 10:44 UTC (permalink / raw)
To: Bárbara Fernandes
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
linux-iio, devel, linux-kernel, Wilson Sales
On Sat, 18 May 2019 19:43:33 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
> Create structure of type of_device_id in order to register all devices
> the driver is able to manage.
>
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed-by: Wilson Sales <spoonm@spoonm.org>
Looks good to me.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
> index 8294b9c1e3c2..9968775f1d23 100644
> --- a/drivers/staging/iio/addac/adt7316-spi.c
> +++ b/drivers/staging/iio/addac/adt7316-spi.c
> @@ -127,9 +127,22 @@ static const struct spi_device_id adt7316_spi_id[] = {
>
> MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
>
> +static const struct of_device_id adt7316_of_spi_match[] = {
> + { .compatible = "adi,adt7316" },
> + { .compatible = "adi,adt7317" },
> + { .compatible = "adi,adt7318" },
> + { .compatible = "adi,adt7516" },
> + { .compatible = "adi,adt7517" },
> + { .compatible = "adi,adt7519" },
> + { }
> +};
> +
> +MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
> +
> static struct spi_driver adt7316_driver = {
> .driver = {
> .name = "adt7316",
> + .of_match_table = adt7316_of_spi_match,
> .pm = ADT7316_PM_OPS,
> },
> .probe = adt7316_spi_probe,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] staging: iio: adt7316: create of_device_id array
2019-05-19 10:44 ` Jonathan Cameron
@ 2019-05-20 9:36 ` Alexandru Ardelean
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Ardelean @ 2019-05-20 9:36 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Bárbara Fernandes, Lars-Peter Clausen, Michael Hennerich,
Stefan Popa, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, linux-iio, devel, LKML, Wilson Sales,
Alexandru Ardelean
On Sun, May 19, 2019 at 8:54 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 19:43:33 -0300
> Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
>
> > Create structure of type of_device_id in order to register all devices
> > the driver is able to manage.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed-by: Wilson Sales <spoonm@spoonm.org>
> Looks good to me.
>
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
>
> Thanks,
Also,
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.
>
> Jonathan
>
> > ---
> > drivers/staging/iio/addac/adt7316-spi.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c
> > index 8294b9c1e3c2..9968775f1d23 100644
> > --- a/drivers/staging/iio/addac/adt7316-spi.c
> > +++ b/drivers/staging/iio/addac/adt7316-spi.c
> > @@ -127,9 +127,22 @@ static const struct spi_device_id adt7316_spi_id[] = {
> >
> > MODULE_DEVICE_TABLE(spi, adt7316_spi_id);
> >
> > +static const struct of_device_id adt7316_of_spi_match[] = {
> > + { .compatible = "adi,adt7316" },
> > + { .compatible = "adi,adt7317" },
> > + { .compatible = "adi,adt7318" },
> > + { .compatible = "adi,adt7516" },
> > + { .compatible = "adi,adt7517" },
> > + { .compatible = "adi,adt7519" },
> > + { }
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, adt7316_of_spi_match);
> > +
> > static struct spi_driver adt7316_driver = {
> > .driver = {
> > .name = "adt7316",
> > + .of_match_table = adt7316_of_spi_match,
> > .pm = ADT7316_PM_OPS,
> > },
> > .probe = adt7316_spi_probe,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-20 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18 22:43 [RESEND PATCH] staging: iio: adt7316: create of_device_id array Bárbara Fernandes
2019-05-19 10:44 ` Jonathan Cameron
2019-05-20 9:36 ` Alexandru Ardelean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).