From: Jonathan Cameron <jic23@kernel.org>
To: "João Seckler" <joaoseckler@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: ad7746: add device tree support
Date: Sun, 19 May 2019 12:02:50 +0100 [thread overview]
Message-ID: <20190519120250.4644c255@archlinux> (raw)
In-Reply-To: <20190518222733.2ttcgvy7fct4awra@smtp.gmail.com>
On Sat, 18 May 2019 19:27:33 -0300
João Seckler <joaoseckler@gmail.com> wrote:
> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
>
> Signed-off-by: João Seckler <joaoseckler@gmail.com>
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
For a future improvement, try to explain the 'why' rather than
'what' of a patch in the description. This particular change
is so common I don't mind that much, but it is a good habit to
get into!
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 47610d863908..21527d84f940 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = {
>
> MODULE_DEVICE_TABLE(i2c, ad7746_id);
>
> +static const struct of_device_id ad7746_of_match[] = {
> + { .compatible = "adi,ad7745" },
> + { .compatible = "adi,ad7746" },
> + { .compatible = "adi,ad7747" },
> + { },
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7746_of_match);
> +
> static struct i2c_driver ad7746_driver = {
> .driver = {
> .name = KBUILD_MODNAME,
> + .of_match_table = ad7746_of_match,
> },
> .probe = ad7746_probe,
> .id_table = ad7746_id,
next prev parent reply other threads:[~2019-05-19 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 22:27 [PATCH] staging: iio: ad7746: add device tree support João Seckler
2019-05-19 11:02 ` Jonathan Cameron [this message]
2019-05-19 11:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519120250.4644c255@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joaoseckler@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).