Linux-IIO Archive on lore.kernel.org
 help / Atom feed
* [PATCH] staging: iio: ad7746: add device tree support
@ 2019-05-18 22:27 João Seckler
  2019-05-19 11:02 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: João Seckler @ 2019-05-18 22:27 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
	Greg Kroah-Hartman
  Cc: linux-iio, devel, linux-kernel

Add a of_device_id struct variable and subsequent call to
MODULE_DEVICE_TABLE macro to support device tree.

Signed-off-by: João Seckler <joaoseckler@gmail.com>
Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
---
 drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 47610d863908..21527d84f940 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = {
 
 MODULE_DEVICE_TABLE(i2c, ad7746_id);
 
+static const struct of_device_id ad7746_of_match[] = {
+	{ .compatible = "adi,ad7745" },
+	{ .compatible = "adi,ad7746" },
+	{ .compatible = "adi,ad7747" },
+	{ },
+};
+
+MODULE_DEVICE_TABLE(of, ad7746_of_match);
+
 static struct i2c_driver ad7746_driver = {
 	.driver = {
 		.name = KBUILD_MODNAME,
+		.of_match_table = ad7746_of_match,
 	},
 	.probe = ad7746_probe,
 	.id_table = ad7746_id,
-- 
2.11.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: iio: ad7746: add device tree support
  2019-05-18 22:27 [PATCH] staging: iio: ad7746: add device tree support João Seckler
@ 2019-05-19 11:02 ` Jonathan Cameron
  2019-05-19 11:09   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-05-19 11:02 UTC (permalink / raw)
  To: João Seckler
  Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
	Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
	linux-iio, devel, linux-kernel

On Sat, 18 May 2019 19:27:33 -0300
João Seckler <joaoseckler@gmail.com> wrote:

> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
> 
> Signed-off-by: João Seckler <joaoseckler@gmail.com>
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

For a future improvement, try to explain the 'why' rather than
'what' of a patch in the description.   This particular change
is so common I don't mind that much, but it is a good habit to
get into!

Thanks,

Jonathan
> ---
>  drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 47610d863908..21527d84f940 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = {
>  
>  MODULE_DEVICE_TABLE(i2c, ad7746_id);
>  
> +static const struct of_device_id ad7746_of_match[] = {
> +	{ .compatible = "adi,ad7745" },
> +	{ .compatible = "adi,ad7746" },
> +	{ .compatible = "adi,ad7747" },
> +	{ },
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7746_of_match);
> +
>  static struct i2c_driver ad7746_driver = {
>  	.driver = {
>  		.name = KBUILD_MODNAME,
> +		.of_match_table = ad7746_of_match,
>  	},
>  	.probe = ad7746_probe,
>  	.id_table = ad7746_id,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: iio: ad7746: add device tree support
  2019-05-19 11:02 ` Jonathan Cameron
@ 2019-05-19 11:09   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-05-19 11:09 UTC (permalink / raw)
  To: João Seckler
  Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
	Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
	linux-iio, devel, linux-kernel

On Sun, 19 May 2019 12:02:50 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sat, 18 May 2019 19:27:33 -0300
> João Seckler <joaoseckler@gmail.com> wrote:
> 
> > Add a of_device_id struct variable and subsequent call to
> > MODULE_DEVICE_TABLE macro to support device tree.
> > 
> > Signed-off-by: João Seckler <joaoseckler@gmail.com>
> > Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> > Co-developed-by: Lucas Oshiro <lucasseikioshiro@gmail.com>  
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
> 
> For a future improvement, try to explain the 'why' rather than
> 'what' of a patch in the description.   This particular change
> is so common I don't mind that much, but it is a good habit to
> get into!
Ah, you do say to support device tree at the end, but more
detail on that would have been good!

Thanks,

J
> 
> Thanks,
> 
> Jonathan
> > ---
> >  drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> > index 47610d863908..21527d84f940 100644
> > --- a/drivers/staging/iio/cdc/ad7746.c
> > +++ b/drivers/staging/iio/cdc/ad7746.c
> > @@ -748,9 +748,19 @@ static const struct i2c_device_id ad7746_id[] = {
> >  
> >  MODULE_DEVICE_TABLE(i2c, ad7746_id);
> >  
> > +static const struct of_device_id ad7746_of_match[] = {
> > +	{ .compatible = "adi,ad7745" },
> > +	{ .compatible = "adi,ad7746" },
> > +	{ .compatible = "adi,ad7747" },
> > +	{ },
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7746_of_match);
> > +
> >  static struct i2c_driver ad7746_driver = {
> >  	.driver = {
> >  		.name = KBUILD_MODNAME,
> > +		.of_match_table = ad7746_of_match,
> >  	},
> >  	.probe = ad7746_probe,
> >  	.id_table = ad7746_id,  
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18 22:27 [PATCH] staging: iio: ad7746: add device tree support João Seckler
2019-05-19 11:02 ` Jonathan Cameron
2019-05-19 11:09   ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox