From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F04C282E1 for ; Sat, 25 May 2019 00:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58F5D217F9 for ; Sat, 25 May 2019 00:28:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pLJLni3Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbfEYA2K (ORCPT ); Fri, 24 May 2019 20:28:10 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35550 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbfEYA2K (ORCPT ); Fri, 24 May 2019 20:28:10 -0400 Received: by mail-qk1-f194.google.com with SMTP id c15so10012349qkl.2; Fri, 24 May 2019 17:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AmssAmMD6meoyYR0aDDzoUlpZp3YaMp7uyas5pLvf4k=; b=pLJLni3YVm7CEOhvdFE06jiSz4ZB0utUzWLpavg1dULdCbYxmL780/JRabKzTqeXYV 65BvIFZjr3CptEHDItqLy3pUujEGDLPLYrIJmP13PuLQUsiUu65H6dKDylvgPAluNWiy 5HD+Sj+ZgxURZHwwkrCF3iJl/pIbOGlclfGcWCnMp4oF9O2e/4CIP0JKuAiRX+QendU3 FjaW4QlZZk/kGPOzNx84m/BM7mSPUqhF0LGTFwd2IlHJq3oSfWyjz9A5dfr7ov3/xZ5/ O26gE/1Kbu79EtnI3HAZkzzab3f1+2PmxQE7ONQGT/Du4H6QJ09N/AKsWD9cEydjCout OpnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AmssAmMD6meoyYR0aDDzoUlpZp3YaMp7uyas5pLvf4k=; b=UUwoyA3fx4BLxM7uXaLTfLjq8HRRxx5nZSm8H9xBJ47hEN+8UEJNBZlOCLN3uA/JGG liOZXDJDlhZmsIiqA3USobiDvXZYWJgZRFp60ZJeVB0dqOL/A6xGxUEpqzznVprh6yVE iJwUEksE14lDDpUqfgFK7wHTT6K5iRcqcW3trjV3hAiOdFkVTlcNOQ0kpZM8ic+gM6KB YwyzelQEl+k838QeX0TCCoqK5j+6htHh0WFHaE7BMkzviQ7KNDVhByOcnkV5lRmTqbOS JhKd0tAA40WvZX/TKfzjO41NV4Gq8SSv5VxquhjBZBymMOoOssKlHv/ux/iLkpotHNnR ZOBg== X-Gm-Message-State: APjAAAXaKMUggbZfMZxVjYThsaV/CLO4C0Ii0/C6dCC6GFe//qDwunMU yCmQzvsffW3zS5Wi6XDaxQI= X-Google-Smtp-Source: APXvYqxBV0dfevd+oUzPwnJDoxpXpjX3opIIx7eCOEn1SejUoJZ7bLZlUwFQCIOHNOEwscFRd6uduw== X-Received: by 2002:ac8:30c6:: with SMTP id w6mr90687923qta.186.1558744088477; Fri, 24 May 2019 17:28:08 -0700 (PDT) Received: from renatolg ([186.220.0.156]) by smtp.gmail.com with ESMTPSA id x8sm1770788qtc.96.2019.05.24.17.28.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 24 May 2019 17:28:08 -0700 (PDT) From: Renato Lui Geh X-Google-Original-From: Renato Lui Geh Date: Fri, 24 May 2019 21:28:02 -0300 To: "Ardelean, Alexandru" Cc: "renatogeh@gmail.com" , "jic23@kernel.org" , "kernel-usp@googlegroups.com" , "lars@metafoo.de" , "robh+dt@kernel.org" , "Popa, Stefan Serban" , "knaack.h@gmx.de" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "Hennerich, Michael" , "linux-iio@vger.kernel.org" , "devel@driverdev.osuosl.org" , "mark.rutland@arm.com" , "pmeerw@pmeerw.net" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH] dt-bindings: iio: adc: add adi,ad7780.yaml binding Message-ID: <20190525002801.ccq54fczbj3wxhan@renatolg> References: <9992a318aec777b9b7788bb40d976aa89e5963fe.1558219042.git.renatogeh@gmail.com> <20190519123208.26c864ce@archlinux> <5d7ad2935d1e357f1c0885badc5ce3c351c8ed89.camel@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <5d7ad2935d1e357f1c0885badc5ce3c351c8ed89.camel@analog.com> User-Agent: NeoMutt/20180716 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Jonathan, Alex, Thanks for the review. Some comments inline. Thanks, Renato On 05/20, Ardelean, Alexandru wrote: >On Sun, 2019-05-19 at 12:32 +0100, Jonathan Cameron wrote: >> [External] >> >> >> On Sat, 18 May 2019 19:41:12 -0300 >> Renato Lui Geh wrote: >> >> > This patch adds a YAML binding for the Analog Devices AD7780/1 and >> > AD7170/1 analog-to-digital converters. >> > >> > Signed-off-by: Renato Lui Geh >> >> One comment inline. I'll also be needing an ack from Analog on this, >> preferably Michael's. >> >> Thanks, >> >> Jonathan >> > --- >> > .../bindings/iio/adc/adi,ad7780.txt | 48 ----------- >> > .../bindings/iio/adc/adi,ad7780.yaml | 85 +++++++++++++++++++ > >You should also update the MAINTAINERS file. >Maybe in a following patch. >It looks like there is not entry in there, so maybe you need to add a new >one. > >Something like: > > >ANALOG DEVICES INC AD7780 DRIVER >M: Michael Hennerich >M: Renato Lui Geh >L: linux-iio@vger.kernel.org >W: http://ez.analog.com/community/linux-device-drivers >S: Supported >F: drivers/iio/adc/ad7780.c >F: Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml > >This should be after this block >ANALOG DEVICES INC AD7768-1 DRIVER > >Note that I added you as a co-maintainer. >If you want, you do not need to add that line. > >> > 2 files changed, 85 insertions(+), 48 deletions(-) >> > delete mode 100644 >> > Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt >> > create mode 100644 >> > Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml >> > >> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt >> > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt >> > deleted file mode 100644 >> > index 440e52555349..000000000000 >> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt >> > +++ /dev/null >> > @@ -1,48 +0,0 @@ >> > -* Analog Devices AD7170/AD7171/AD7780/AD7781 >> > - >> > -Data sheets: >> > - >> > -- AD7170: >> > - * >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf >> > -- AD7171: >> > - * >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf >> > -- AD7780: >> > - * >> > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf >> > -- AD7781: >> > - * >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf >> > - >> > -Required properties: >> > - >> > -- compatible: should be one of >> > - * "adi,ad7170" >> > - * "adi,ad7171" >> > - * "adi,ad7780" >> > - * "adi,ad7781" >> > -- reg: spi chip select number for the device >> > -- vref-supply: the regulator supply for the ADC reference voltage >> > - >> > -Optional properties: >> > - >> > -- powerdown-gpios: must be the device tree identifier of the PDRST >> > pin. If >> > - specified, it will be asserted during driver probe. >> > As the >> > - line is active high, it should be marked >> > GPIO_ACTIVE_HIGH. >> > -- adi,gain-gpios: must be the device tree identifier of the GAIN >> > pin. Only for >> > - the ad778x chips. If specified, it will be asserted >> > during >> > - driver probe. As the line is active low, it should be >> > marked >> > - GPIO_ACTIVE_LOW. >> > -- adi,filter-gpios: must be the device tree identifier of the FILTER >> > pin. Only >> > - for the ad778x chips. If specified, it will be >> > asserted >> > - during driver probe. As the line is active low, it >> > should be >> > - marked GPIO_ACTIVE_LOW. >> > - >> > -Example: >> > - >> > -adc@0 { >> > - compatible = "adi,ad7780"; >> > - reg = <0>; >> > - vref-supply = <&vdd_supply> >> > - >> > - powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>; >> > - adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; >> > - adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>; >> > -}; >> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml >> > b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml >> > new file mode 100644 >> > index 000000000000..931bc4f8ec04 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml >> > @@ -0,0 +1,85 @@ >> > +# SPDX-License-Identifier: GPL-2.0 >> > +%YAML 1.2 >> > +--- >> > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7780.yaml# >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# >> > + >> > +title: Analog Devices AD7170/AD7171/AD7780/AD7781 analog to digital >> > converters >> > + >> > +maintainers: >> > + - Michael Hennerich >> > + >> > +description: | >> > + The ad7780 is a sigma-delta analog to digital converter. This driver >> > provides >> > + reading voltage values and status bits from both the ad778x and >> > ad717x series. >> > + Its interface also allows writing on the FILTER and GAIN GPIO pins >> > on the >> > + ad778x. >> > + >> > + Specifications on the converters can be found at: >> > + AD7170: >> > + >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7170.pdf >> > + AD7171: >> > + >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7171.pdf >> > + AD7780: >> > + >> > https://www.analog.com/media/en/technical-documentation/data-sheets/ad7780.pdf >> > + AD7781: >> > + >> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD7781.pdf >> > + >> > +properties: >> > + compatible: >> > + enum: >> > + - adi,ad7170 >> > + - adi,ad7171 >> > + - adi,ad7780 >> > + - adi,ad7781 >> > + >> > + reg: >> > + description: >> > + Chip select number for the device > >No need to add a description. >This is pretty standard. > >> > + maxItems: 1 >> > + >> > + vref-supply: >> > + description: >> > + The regulator supply for the ADC reference voltage >> > + maxItems: 1 >> > + > >As I see in the driver, it's not vref-supply, it's avdd-supply. You're absolutely right. Shouldn't have mindlessly copied from the txt, even though the txt's was also my fault. By the way, a quick look at ad7170 and ad7780's datasheets shows that the 7170 uses VDD, and the 7780, AVDD. Are they equivalent? > >> > + powerdown-gpios: >> > + description: >> > + Must be the device tree identifier of the PDRST pin. If >> > + specified, it will be asserted during driver probe. As the >> > + line is active high, it should be marked GPIO_ACTIVE_HIGH. >> > + maxItems: 1 >> > + >> > + adi,gain-gpios: >> > + description: >> > + Must be the device tree identifier of the GAIN pin. Only for >> > + the ad778x chips. If specified, it will be asserted during >> > + driver probe. As the line is active low, it should be marked >> > + GPIO_ACTIVE_LOW. >> > + maxItems: 1 >> > + >> > + adi,filter-gpios: >> > + description: >> > + Must be the device tree identifier of the FILTER pin. Only >> > + for the ad778x chips. If specified, it will be asserted >> > + during driver probe. As the line is active low, it should be >> > + marked GPIO_ACTIVE_LOW. >> > + maxItems: 1 >> > + >> > +required: >> > + - compatible >> > + - reg >> > + - vref-supply >> >> Is that actually true? I'd imagine it'll use a stub regulator if >> it isn't supplied. > >Hmm, I also think this can be omitted as required. >devm_regulator_get() is used. >devm_regulator_get_exclusive() would be needed to make this required. I see. So the difference between devm_regulator_get and devm_regulator_get_optional is that the former uses a stub when the requested reg isn't supplied, and the latter doesn't? > >> >> > + >> > +examples: >> > + - | >> > + #include >> > + adc@0 { > >The adc@0 block should be included in a spi block. > >So, something like > >spi0 { > adc@0 { > compatible = "adi,ad7780"; > reg = <0>; > avdd-supply = <&vdd_supply> > > powerdown-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>; > adi,gain-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; > adi,filter-gpios = <&gpio 15 GPIO_ACTIVE_LOW>; > }; >}; > >I know this wasn't the case before, but it should be (from what I recall). > >> > + compatible = "adi,ad7780"; >> > + reg = <0>; >> > + vref-supply = <&vdd_supply>; >> > + >> > + powerdown-gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>; >> > + adi,gain-gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; >> > + adi,filter-gpios = <&gpio2 15 GPIO_ACTIVE_LOW>; > >Rest looks good. > >Thanks >Alex > >> > + }; >> >>