Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: iio: adt7316: Add missing include files
@ 2019-06-14 15:28 YueHaibing
  2019-06-16 13:11 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-06-14 15:28 UTC (permalink / raw)
  To: gregkh, lars, Michael.Hennerich, stefan.popa, jic23, knaack.h, pmeerw
  Cc: linux-kernel, devel, linux-iio, YueHaibing

Fix build error:

drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
 function gpiod_set_value; did you mean gpio_set_value? [-Werror=implicit-function-declaration]
   gpiod_set_value(chip->ldac_pin, 0);

drivers/staging/iio/addac/adt7316.c: In function adt7316_setup_irq:
drivers/staging/iio/addac/adt7316.c:1807:13: error: implicit declaration of
 function irqd_get_trigger_type; did you mean devm_iio_trigger_free? [-Werror=implicit-function-declaration]
  irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq));

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()")
Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/staging/iio/addac/adt7316.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 37ce563..9d3d159 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -16,6 +16,8 @@
 #include <linux/i2c.h>
 #include <linux/rtc.h>
 #include <linux/module.h>
+#include <linux/irq.h>
+#include <linux/gpio/consumer.h>
 
 #include <linux/iio/iio.h>
 #include <linux/iio/events.h>
-- 
2.7.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: iio: adt7316: Add missing include files
  2019-06-14 15:28 [PATCH] staging: iio: adt7316: Add missing include files YueHaibing
@ 2019-06-16 13:11 ` Jonathan Cameron
  2019-06-17  1:26   ` Yuehaibing
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-06-16 13:11 UTC (permalink / raw)
  To: YueHaibing
  Cc: gregkh, lars, Michael.Hennerich, stefan.popa, knaack.h, pmeerw,
	linux-kernel, devel, linux-iio

On Fri, 14 Jun 2019 23:28:46 +0800
YueHaibing <yuehaibing@huawei.com> wrote:

> Fix build error:
> 
> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
> drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
>  function gpiod_set_value; did you mean gpio_set_value? [-Werror=implicit-function-declaration]
>    gpiod_set_value(chip->ldac_pin, 0);
> 
> drivers/staging/iio/addac/adt7316.c: In function adt7316_setup_irq:
> drivers/staging/iio/addac/adt7316.c:1807:13: error: implicit declaration of
>  function irqd_get_trigger_type; did you mean devm_iio_trigger_free? [-Werror=implicit-function-declaration]
>   irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq));
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()")
> Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Hi yuehaibing,

You were second to send a fix for this. I've had it in my
fixes branch since last week, but not done a pull request quite yet.
I'll probably send it out later today.

https://patchwork.kernel.org/patch/10978301/

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 37ce563..9d3d159 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -16,6 +16,8 @@
>  #include <linux/i2c.h>
>  #include <linux/rtc.h>
>  #include <linux/module.h>
> +#include <linux/irq.h>
> +#include <linux/gpio/consumer.h>
>  
>  #include <linux/iio/iio.h>
>  #include <linux/iio/events.h>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: iio: adt7316: Add missing include files
  2019-06-16 13:11 ` Jonathan Cameron
@ 2019-06-17  1:26   ` Yuehaibing
  0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-06-17  1:26 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: gregkh, lars, Michael.Hennerich, stefan.popa, knaack.h, pmeerw,
	linux-kernel, devel, linux-iio

On 2019/6/16 21:11, Jonathan Cameron wrote:
> On Fri, 14 Jun 2019 23:28:46 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
> 
>> Fix build error:
>>
>> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
>> drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
>>  function gpiod_set_value; did you mean gpio_set_value? [-Werror=implicit-function-declaration]
>>    gpiod_set_value(chip->ldac_pin, 0);
>>
>> drivers/staging/iio/addac/adt7316.c: In function adt7316_setup_irq:
>> drivers/staging/iio/addac/adt7316.c:1807:13: error: implicit declaration of
>>  function irqd_get_trigger_type; did you mean devm_iio_trigger_free? [-Werror=implicit-function-declaration]
>>   irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq));
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()")
>> Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Hi yuehaibing,
> 
> You were second to send a fix for this. I've had it in my
> fixes branch since last week, but not done a pull request quite yet.
> I'll probably send it out later today.

Sorry, our robot report this again and I forgot this ...

> 
> https://patchwork.kernel.org/patch/10978301/
> 
> Thanks,
> 
> Jonathan
> 
>> ---
>>  drivers/staging/iio/addac/adt7316.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
>> index 37ce563..9d3d159 100644
>> --- a/drivers/staging/iio/addac/adt7316.c
>> +++ b/drivers/staging/iio/addac/adt7316.c
>> @@ -16,6 +16,8 @@
>>  #include <linux/i2c.h>
>>  #include <linux/rtc.h>
>>  #include <linux/module.h>
>> +#include <linux/irq.h>
>> +#include <linux/gpio/consumer.h>
>>  
>>  #include <linux/iio/iio.h>
>>  #include <linux/iio/events.h>
> 
> 
> .
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 15:28 [PATCH] staging: iio: adt7316: Add missing include files YueHaibing
2019-06-16 13:11 ` Jonathan Cameron
2019-06-17  1:26   ` Yuehaibing

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox