From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A415EC48BD6 for ; Wed, 26 Jun 2019 20:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72564216FD for ; Wed, 26 Jun 2019 20:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561580018; bh=0jQodpDRuAkFZgDiEgerdZvI7o/ZwZ0KSv4xKSQprD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=l6oxaT8f7myynDNRA/d7g7z1EwUZa5kYaQDCkPye98tNGvXxoKTGgSsBQlYkVgOq7 nnFZ68lBYcxC8LWzwf4ZfwnSYvyBotF6zblcDRz2l7x5P9G9QHQlltVnlVg/8Jq5FB jEJjKczLBYrx7R3W7bFjOBIt3tXSOD6xqRYuL/xg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbfFZUNi (ORCPT ); Wed, 26 Jun 2019 16:13:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:44354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfFZUNh (ORCPT ); Wed, 26 Jun 2019 16:13:37 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8EA32086D; Wed, 26 Jun 2019 20:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561580016; bh=0jQodpDRuAkFZgDiEgerdZvI7o/ZwZ0KSv4xKSQprD8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tiV3ftktTDsuAQeR2z4Vu6D7XRs6u+SF4+yX/FgFVai8l8bUkuTUjNKxRN+hTBvVu aNhjRw7hskTBnc6xC++D5aSsmyL4+HvgvW4E7J1VEXO4x13+P8xYWfipHsMIrwoQ0S hdTU5lJgCY0k6PYgyysagmt1viul5eTn+QvL1jao= Date: Wed, 26 Jun 2019 21:13:31 +0100 From: Jonathan Cameron To: Rob Herring Cc: Stefan Popa , Mark Rutland , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Michael Hennerich , Greg Kroah-Hartman , "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4] iio: frequency: adf4371: Add support for output stage mute Message-ID: <20190626211331.6e335fe8@archlinux> In-Reply-To: References: <1561389236-26464-1-git-send-email-stefan.popa@analog.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 26 Jun 2019 13:59:49 -0600 Rob Herring wrote: > On Mon, Jun 24, 2019 at 9:14 AM Stefan Popa wrote: > > > > Another feature of the ADF4371/ADF4372 is that the supply current to the > > RF8P and RF8N output stage can shut down until the ADF4371 achieves lock > > as measured by the digital lock detect circuitry. The mute to lock > > detect bit (MUTE_LD) in REG25 enables this function. > > > > Signed-off-by: Stefan Popa > > --- > > .../devicetree/bindings/iio/frequency/adf4371.yaml | 6 ++++++ > > If you resend and in the future, please split bindings to separate patch. > > > drivers/iio/frequency/adf4371.c | 13 +++++++++++++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > index a268a9d..6db8742 100644 > > --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > @@ -32,6 +32,12 @@ properties: > > items: > > - clkin > > > > + adi,mute-till-lock-en: > > + description: > > + If this property is present, then the supply current to RF8P and RF8N > > + output stage will shut down until the ADF4371/ADF4372 achieves lock as > > + measured by the digital lock detect circuitry. > > You need to define the type: > > type: boolean > > Maybe Jonathan will fix up. Doh. I should have caught that. Fixed up with type: boolean Hopefully I did it right https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=6e68162fcc94ec81c1656e15e6e1893fee0c309a Thanks Rob! Jonathan > > Rob