From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F00DC73C66 for ; Sun, 14 Jul 2019 17:23:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE81C2089C for ; Sun, 14 Jul 2019 17:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563124998; bh=GsHSvqL6z/sCzYKnP0NDpupg8hBjmVrWg62QPwDln0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=fMrwHOj38I94CyHHSb0t3X8EUiIeNTIqozv/bZWfGYu0S9M3kgvGG0sgQirPLBaGt 7C+6zsSlCNEVOcD6s/fbZ3fDg7AA70adwcZvtxu3FG6LjPpRQAx68gXs0yeYce27YE KMgjPqJ3aQn9Oq2+PrHjdjONZ7lSwIbxVeLMW6rc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbfGNRXS (ORCPT ); Sun, 14 Jul 2019 13:23:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:42262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbfGNRXS (ORCPT ); Sun, 14 Jul 2019 13:23:18 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 763CF2063F; Sun, 14 Jul 2019 17:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563124996; bh=GsHSvqL6z/sCzYKnP0NDpupg8hBjmVrWg62QPwDln0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fWtta0StSeOZebigeRXdyHpnP9KgOGqhcNbtnzlbuWqGkRfVA4q6+XtVo9KKz5TUA FH9gXNEbilo9DzXlg3SHw5lAL9ZQTlQW02V6ZaFzv1tq5Zr2mMpoSS0rn+yr1BuoMd MLP+pa/sBEHbo/YGn5B4Z8qPKCO2fNDILAV0luw0= Date: Sun, 14 Jul 2019 18:23:07 +0100 From: Jonathan Cameron To: Benjamin GAIGNARD Cc: William Breathitt Gray , Benjamin Gaignard , Lars-Peter Clausen , Alexandre TORGUE , "linux-iio@vger.kernel.org" , "Linux Kernel Mailing List" , Peter Meerwald-Stadler , Hartmut Knaack , Fabrice GASNIER , "linux-stm32@st-md-mailman.stormreply.com" , Linux ARM Subject: Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver Message-ID: <20190714182307.71df9b00@archlinux> In-Reply-To: <08b3f84e-cee4-4fbe-031d-721aa9dc53d4@st.com> References: <20190507091224.17781-1-benjamin.gaignard@st.com> <20190711115059.GA7778@icarus> <20190711121620.GA11661@icarus> <20190714110901.752643ae@archlinux> <08b3f84e-cee4-4fbe-031d-721aa9dc53d4@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 14 Jul 2019 15:32:33 +0000 Benjamin GAIGNARD wrote: > On 7/14/19 12:09 PM, Jonathan Cameron wrote: > > On Thu, 11 Jul 2019 21:16:20 +0900 > > William Breathitt Gray wrote: > > =20 > >> On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote: =20 > >>> Le jeu. 11 juil. 2019 =C3=A0 13:51, William Breathitt Gray > >>> a =C3=A9crit : =20 > >>>> On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote: = =20 > >>>>> Quadrature feature is now hosted on it own framework. > >>>>> Remove quadrature related code from stm32-trigger driver to avoid > >>>>> code duplication and simplify the ABI. > >>>>> > >>>>> Signed-off-by: Benjamin Gaignard =20 > >>>> What is the status of this patch? Are there any objections currently= for > >>>> its inclusion? =20 > >>> You were the only one asking for more details about it :-) > >>> If you agree I think that Jonathan can merge it. > >>> > >>> Benjamin =20 > >>>> William Breathitt Gray > >>>> > >>>> _______________________________________________ > >>>> linux-arm-kernel mailing list > >>>> linux-arm-kernel@lists.infradead.org > >>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel =20 > >> Yes, Jonathan please merge this if you have no objections, I hadn't > >> realized I was delaying it. > >> > >> Thank you, > >> > >> William Breathitt Gray =20 > > One last thing... This seems to be a userspace ABI change. What > > are our potential issues with users of this ABI? > > > > It's not that costly to keep the code, though dropping the docs or > > putting a depreciated note in them is probably a good idea. Hence > > I'm not totally convinced the risk of a regression is worth it. =20 >=20 > As far I know nobody use this interface yet for me there is no risk to=20 > remove this code. >=20 > Benjamin Hope you are right :) Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan >=20 > > > > If we think it's the sort of change no one will notice, then > > fair enough we'll give it a go and cross our fingers. > > > > Thanks, > > > > Jonathan > > > =20