linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: jic23@kernel.org, lorenzo.bianconi@redhat.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: imu: st_lsm6dsx: inline acc/gyro output regs
Date: Tue, 16 Jul 2019 08:24:00 +0200	[thread overview]
Message-ID: <20190716062400.GF23126@localhost.localdomain> (raw)
In-Reply-To: <7d42aba0-c98c-5ffb-2a1d-473ad5607ad5@puri.sm>

[-- Attachment #1: Type: text/plain, Size: 2817 bytes --]

> On 15.07.19 23:42, Lorenzo Bianconi wrote:
> > Remove output register definitions and inline register values since
> > they are used only for iio channel definitions. This is a preliminary
> > patch to add support for LSM9DS1 sensor to st_lsm6dsx driver
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 26 +++++---------------
> >  1 file changed, 6 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > index 9aa109428a52..0abd5b85b398 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -61,14 +61,6 @@
> >  #define ST_LSM6DSX_REG_INT2_ON_INT1_ADDR	0x13
> >  #define ST_LSM6DSX_REG_INT2_ON_INT1_MASK	BIT(5)
> >  
> > -#define ST_LSM6DSX_REG_ACC_OUT_X_L_ADDR		0x28
> > -#define ST_LSM6DSX_REG_ACC_OUT_Y_L_ADDR		0x2a
> > -#define ST_LSM6DSX_REG_ACC_OUT_Z_L_ADDR		0x2c
> > -
> > -#define ST_LSM6DSX_REG_GYRO_OUT_X_L_ADDR	0x22
> > -#define ST_LSM6DSX_REG_GYRO_OUT_Y_L_ADDR	0x24
> > -#define ST_LSM6DSX_REG_GYRO_OUT_Z_L_ADDR	0x26
> > -
> >  static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> >  	{
> >  		.wai = 0x69,
> > @@ -701,22 +693,16 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> >  };
> >  
> >  static const struct iio_chan_spec st_lsm6dsx_acc_channels[] = {
> > -	ST_LSM6DSX_CHANNEL(IIO_ACCEL, ST_LSM6DSX_REG_ACC_OUT_X_L_ADDR,
> > -			   IIO_MOD_X, 0),
> > -	ST_LSM6DSX_CHANNEL(IIO_ACCEL, ST_LSM6DSX_REG_ACC_OUT_Y_L_ADDR,
> > -			   IIO_MOD_Y, 1),
> > -	ST_LSM6DSX_CHANNEL(IIO_ACCEL, ST_LSM6DSX_REG_ACC_OUT_Z_L_ADDR,
> > -			   IIO_MOD_Z, 2),
> > +	ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x28, IIO_MOD_X, 0),
> > +	ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2a, IIO_MOD_Y, 1),
> > +	ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2c, IIO_MOD_Z, 2),
> >  	IIO_CHAN_SOFT_TIMESTAMP(3),
> >  };
> >  
> >  static const struct iio_chan_spec st_lsm6dsx_gyro_channels[] = {
> > -	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, ST_LSM6DSX_REG_GYRO_OUT_X_L_ADDR,
> > -			   IIO_MOD_X, 0),
> > -	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, ST_LSM6DSX_REG_GYRO_OUT_Y_L_ADDR,
> > -			   IIO_MOD_Y, 1),
> > -	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, ST_LSM6DSX_REG_GYRO_OUT_Z_L_ADDR,
> > -			   IIO_MOD_Z, 2),
> > +	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x22, IIO_MOD_X, 0),
> > +	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x24, IIO_MOD_Y, 1),
> > +	ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x26, IIO_MOD_Z, 2),
> >  	IIO_CHAN_SOFT_TIMESTAMP(3),
> >  };
> >  
> > 
> 
> The definitions don't hurt, even if only used once, or do they?
> 
> thanks,

we can avoid multiple definitions in this way

Lorenzo

>                              martin
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2019-07-16  6:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 21:42 [PATCH 0/3] st_lsm6dsx: move {odr,fs}_table in Lorenzo Bianconi
2019-07-15 21:42 ` [PATCH 1/3] iio: imu: st_lsm6dsx: move odr_table in st_lsm6dsx_sensor_settings Lorenzo Bianconi
2019-07-16  6:07   ` Martin Kepplinger
2019-07-16  6:25     ` Lorenzo Bianconi
2019-07-16  7:17   ` Martin Kepplinger
2019-07-16  9:13   ` Martin Kepplinger
2019-07-15 21:42 ` [PATCH 2/3] iio: imu: st_lsm6dsx: move fs_table " Lorenzo Bianconi
2019-07-16  7:18   ` Martin Kepplinger
2019-07-16  9:13   ` Martin Kepplinger
2019-07-15 21:42 ` [PATCH 3/3] iio: imu: st_lsm6dsx: inline acc/gyro output regs Lorenzo Bianconi
2019-07-16  6:04   ` Martin Kepplinger
2019-07-16  6:24     ` Lorenzo Bianconi [this message]
2019-07-23  5:41 ` [PATCH 0/3] st_lsm6dsx: move {odr,fs}_table in Martin Kepplinger
2019-07-25  5:37   ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716062400.GF23126@localhost.localdomain \
    --to=lorenzo@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=martin.kepplinger@puri.sm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).