From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: jic23@kernel.org, lorenzo.bianconi@redhat.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: imu: st_lsm6dsx: move odr_table in st_lsm6dsx_sensor_settings
Date: Tue, 16 Jul 2019 08:25:23 +0200 [thread overview]
Message-ID: <20190716062523.GG23126@localhost.localdomain> (raw)
In-Reply-To: <f359967f-b696-d442-8dfd-7ee2217f215e@puri.sm>
[-- Attachment #1: Type: text/plain, Size: 11537 bytes --]
> On 15.07.19 23:42, Lorenzo Bianconi wrote:
> > Move sensor odr table in st_lsm6dsx_sensor_settings in order to support
> > sensors with different odr maps. This is a preliminary patch to add
> > support for LSM9DS1 sensor to st_lsm6dsx driver
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 2 +
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 196 ++++++++++++++++---
> > 2 files changed, 166 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > index af379a5429ed..3a89f3f6e2c7 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
> > @@ -200,6 +200,7 @@ struct st_lsm6dsx_ext_dev_settings {
> > * @wai: Sensor WhoAmI default value.
> > * @max_fifo_size: Sensor max fifo length in FIFO words.
> > * @id: List of hw id/device name supported by the driver configuration.
> > + * @odr_table: Hw sensors odr table (Hz + val).
> > * @decimator: List of decimator register info (addr + mask).
> > * @batch: List of FIFO batching register info (addr + mask).
> > * @fifo_ops: Sensor hw FIFO parameters.
> > @@ -213,6 +214,7 @@ struct st_lsm6dsx_settings {
> > enum st_lsm6dsx_hw_id hw_id;
> > const char *name;
> > } id[ST_LSM6DSX_MAX_ID];
> > + struct st_lsm6dsx_odr_table_entry odr_table[2];
> > struct st_lsm6dsx_reg decimator[ST_LSM6DSX_MAX_ID];
> > struct st_lsm6dsx_reg batch[ST_LSM6DSX_MAX_ID];
> > struct st_lsm6dsx_fifo_ops fifo_ops;
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > index d8c4417cf4eb..b3c6c9792913 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -69,33 +69,6 @@
> > #define ST_LSM6DSX_REG_GYRO_OUT_Y_L_ADDR 0x24
> > #define ST_LSM6DSX_REG_GYRO_OUT_Z_L_ADDR 0x26
> >
> > -static const struct st_lsm6dsx_odr_table_entry st_lsm6dsx_odr_table[] = {
> > - [ST_LSM6DSX_ID_ACC] = {
> > - .reg = {
> > - .addr = 0x10,
> > - .mask = GENMASK(7, 4),
> > - },
> > - .odr_avl[0] = { 13, 0x01 },
> > - .odr_avl[1] = { 26, 0x02 },
> > - .odr_avl[2] = { 52, 0x03 },
> > - .odr_avl[3] = { 104, 0x04 },
> > - .odr_avl[4] = { 208, 0x05 },
> > - .odr_avl[5] = { 416, 0x06 },
> > - },
> > - [ST_LSM6DSX_ID_GYRO] = {
> > - .reg = {
> > - .addr = 0x11,
> > - .mask = GENMASK(7, 4),
> > - },
> > - .odr_avl[0] = { 13, 0x01 },
> > - .odr_avl[1] = { 26, 0x02 },
> > - .odr_avl[2] = { 52, 0x03 },
> > - .odr_avl[3] = { 104, 0x04 },
> > - .odr_avl[4] = { 208, 0x05 },
> > - .odr_avl[5] = { 416, 0x06 },
> > - }
> > -};
> > -
> > static const struct st_lsm6dsx_fs_table_entry st_lsm6dsx_fs_table[] = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .reg = {
> > @@ -129,6 +102,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_LSM6DS3_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .decimator = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x08,
> > @@ -179,6 +178,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_LSM6DS3H_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .decimator = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x08,
> > @@ -238,6 +263,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_LSM6DS3TRC_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .decimator = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x08,
> > @@ -291,6 +342,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_LSM6DSOX_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .batch = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x09,
> > @@ -359,6 +436,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_ASM330LHH_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .batch = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x09,
> > @@ -401,6 +504,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > .name = ST_LSM6DSR_DEV_NAME,
> > },
> > },
> > + .odr_table = {
> > + [ST_LSM6DSX_ID_ACC] = {
> > + .reg = {
> > + .addr = 0x10,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + [ST_LSM6DSX_ID_GYRO] = {
> > + .reg = {
> > + .addr = 0x11,
> > + .mask = GENMASK(7, 4),
> > + },
> > + .odr_avl[0] = { 13, 0x01 },
> > + .odr_avl[1] = { 26, 0x02 },
> > + .odr_avl[2] = { 52, 0x03 },
> > + .odr_avl[3] = { 104, 0x04 },
> > + .odr_avl[4] = { 208, 0x05 },
> > + .odr_avl[5] = { 416, 0x06 },
> > + },
> > + },
> > .batch = {
> > [ST_LSM6DSX_ID_ACC] = {
> > .addr = 0x09,
> > @@ -563,20 +692,22 @@ static int st_lsm6dsx_set_full_scale(struct st_lsm6dsx_sensor *sensor,
> >
> > int st_lsm6dsx_check_odr(struct st_lsm6dsx_sensor *sensor, u16 odr, u8 *val)
> > {
> > + const struct st_lsm6dsx_odr_table_entry *odr_table;
> > int i;
> >
> > + odr_table = &sensor->hw->settings->odr_table[sensor->id];
> > for (i = 0; i < ST_LSM6DSX_ODR_LIST_SIZE; i++)
> > /*
> > * ext devices can run at different odr respect to
> > * accel sensor
> > */
> > - if (st_lsm6dsx_odr_table[sensor->id].odr_avl[i].hz >= odr)
> > + if (odr_table->odr_avl[i].hz >= odr)
> > break;
> >
> > if (i == ST_LSM6DSX_ODR_LIST_SIZE)
> > return -EINVAL;
> >
> > - *val = st_lsm6dsx_odr_table[sensor->id].odr_avl[i].val;
> > + *val = odr_table->odr_avl[i].val;
> >
> > return 0;
> > }
> > @@ -641,7 +772,7 @@ static int st_lsm6dsx_set_odr(struct st_lsm6dsx_sensor *sensor, u16 req_odr)
> > return err;
> > }
> >
> > - reg = &st_lsm6dsx_odr_table[ref_sensor->id].reg;
> > + reg = &hw->settings->odr_table[ref_sensor->id].reg;
> > data = ST_LSM6DSX_SHIFT_VAL(val, reg->mask);
> > return st_lsm6dsx_update_bits_locked(hw, reg->addr, reg->mask, data);
> > }
> > @@ -786,11 +917,12 @@ st_lsm6dsx_sysfs_sampling_frequency_avail(struct device *dev,
> > {
> > struct st_lsm6dsx_sensor *sensor = iio_priv(dev_get_drvdata(dev));
> > enum st_lsm6dsx_sensor_id id = sensor->id;
> > + struct st_lsm6dsx_hw *hw = sensor->hw;
> > int i, len = 0;
> >
> > for (i = 0; i < ST_LSM6DSX_ODR_LIST_SIZE; i++)
> > len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
> > - st_lsm6dsx_odr_table[id].odr_avl[i].hz);
> > + hw->settings->odr_table[id].odr_avl[i].hz);
> > buf[len - 1] = '\n';
> >
> > return len;
> > @@ -1040,7 +1172,7 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw,
> > sensor = iio_priv(iio_dev);
> > sensor->id = id;
> > sensor->hw = hw;
> > - sensor->odr = st_lsm6dsx_odr_table[id].odr_avl[0].hz;
> > + sensor->odr = hw->settings->odr_table[id].odr_avl[0].hz;
> > sensor->gain = st_lsm6dsx_fs_table[id].fs_avl[0].gain;
> > sensor->watermark = 1;
> >
> >
>
> Makes sense to me, thanks! What tree do you build this against though?
> At least to the current -next tree, this doesn't apply.
>
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
testing branch
Lorenzo
> thanks,
>
> martin
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-07-16 6:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 21:42 [PATCH 0/3] st_lsm6dsx: move {odr,fs}_table in Lorenzo Bianconi
2019-07-15 21:42 ` [PATCH 1/3] iio: imu: st_lsm6dsx: move odr_table in st_lsm6dsx_sensor_settings Lorenzo Bianconi
2019-07-16 6:07 ` Martin Kepplinger
2019-07-16 6:25 ` Lorenzo Bianconi [this message]
2019-07-16 7:17 ` Martin Kepplinger
2019-07-16 9:13 ` Martin Kepplinger
2019-07-15 21:42 ` [PATCH 2/3] iio: imu: st_lsm6dsx: move fs_table " Lorenzo Bianconi
2019-07-16 7:18 ` Martin Kepplinger
2019-07-16 9:13 ` Martin Kepplinger
2019-07-15 21:42 ` [PATCH 3/3] iio: imu: st_lsm6dsx: inline acc/gyro output regs Lorenzo Bianconi
2019-07-16 6:04 ` Martin Kepplinger
2019-07-16 6:24 ` Lorenzo Bianconi
2019-07-23 5:41 ` [PATCH 0/3] st_lsm6dsx: move {odr,fs}_table in Martin Kepplinger
2019-07-25 5:37 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716062523.GG23126@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=martin.kepplinger@puri.sm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).