* [PATCH] iio: frequency: adf4371: Fix output frequency setting
@ 2019-08-05 13:37 Nuno Sá
2019-08-05 14:52 ` Popa, Stefan Serban
0 siblings, 1 reply; 3+ messages in thread
From: Nuno Sá @ 2019-08-05 13:37 UTC (permalink / raw)
To: linux-iio; +Cc: stefan.popa, jic23, Michael.Hennerich
The fract1 word was not being properly programmed on the device leading
to wrong output frequencies.
Fixes: 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371 PLL)
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/iio/frequency/adf4371.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/frequency/adf4371.c b/drivers/iio/frequency/adf4371.c
index e48f15cc9ab5..ff82863cbf42 100644
--- a/drivers/iio/frequency/adf4371.c
+++ b/drivers/iio/frequency/adf4371.c
@@ -276,11 +276,11 @@ static int adf4371_set_freq(struct adf4371_state *st, unsigned long long freq,
st->buf[0] = st->integer >> 8;
st->buf[1] = 0x40; /* REG12 default */
st->buf[2] = 0x00;
- st->buf[3] = st->fract2 & 0xFF;
- st->buf[4] = st->fract2 >> 7;
- st->buf[5] = st->fract2 >> 15;
+ st->buf[3] = st->fract1 & 0xFF;
+ st->buf[4] = st->fract1 >> 8;
+ st->buf[5] = st->fract1 >> 16;
st->buf[6] = ADF4371_FRAC2WORD_L(st->fract2 & 0x7F) |
- ADF4371_FRAC1WORD(st->fract1 >> 23);
+ ADF4371_FRAC1WORD(st->fract1 >> 24);
st->buf[7] = ADF4371_FRAC2WORD_H(st->fract2 >> 7);
st->buf[8] = st->mod2 & 0xFF;
st->buf[9] = ADF4371_MOD2WORD(st->mod2 >> 8);
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: frequency: adf4371: Fix output frequency setting
2019-08-05 13:37 [PATCH] iio: frequency: adf4371: Fix output frequency setting Nuno Sá
@ 2019-08-05 14:52 ` Popa, Stefan Serban
2019-08-05 16:40 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Popa, Stefan Serban @ 2019-08-05 14:52 UTC (permalink / raw)
To: linux-iio, Sa, Nuno; +Cc: jic23, Hennerich, Michael
> The fract1 word was not being properly programmed on the device leading
> to wrong output frequencies.
>
> Fixes: 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371
> PLL)
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/iio/frequency/adf4371.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Popa <stefan.popa@analog.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: frequency: adf4371: Fix output frequency setting
2019-08-05 14:52 ` Popa, Stefan Serban
@ 2019-08-05 16:40 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-08-05 16:40 UTC (permalink / raw)
To: Popa, Stefan Serban; +Cc: linux-iio, Sa, Nuno, Hennerich, Michael
On Mon, 5 Aug 2019 14:52:44 +0000
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com> wrote:
> > The fract1 word was not being properly programmed on the device leading
> > to wrong output frequencies.
> >
> > Fixes: 7f699bd14913 (iio: frequency: adf4371: Add support for ADF4371
> > PLL)
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/frequency/adf4371.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Stefan Popa <stefan.popa@analog.com>
>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 13:37 [PATCH] iio: frequency: adf4371: Fix output frequency setting Nuno Sá
2019-08-05 14:52 ` Popa, Stefan Serban
2019-08-05 16:40 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).