From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7241BC433FF for ; Tue, 6 Aug 2019 09:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F6A420B1F for ; Tue, 6 Aug 2019 09:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731711AbfHFJQH convert rfc822-to-8bit (ORCPT ); Tue, 6 Aug 2019 05:16:07 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:36474 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728845AbfHFJQH (ORCPT ); Tue, 6 Aug 2019 05:16:07 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2F694C01BE73E5489AC0; Tue, 6 Aug 2019 17:16:05 +0800 (CST) Received: from localhost (10.202.226.61) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Tue, 6 Aug 2019 17:16:01 +0800 Date: Tue, 6 Aug 2019 10:15:53 +0100 From: Jonathan Cameron To: Jean-Baptiste Maneyrol CC: Jonathan Cameron , "linux-iio@vger.kernel.org" Subject: Re: [PATCH] iio: imu: inv_mpu6050: add header include protection macro Message-ID: <20190806101553.00004245@huawei.com> In-Reply-To: References: <20190805122513.8399-1-jmaneyrol@invensense.com> <20190805173226.71757a05@archlinux> Organization: Huawei X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.61] X-CFilter-Loop: Reflected Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 6 Aug 2019 08:05:09 +0000 Jean-Baptiste Maneyrol wrote: > Hi Jonathan, > > this is required for further patches coming soon. > > I am planning to add support for full 9-axis on MPU9250, using the chip i2c master to drive the integrated magnetometer and retrieve all data in the MPU FIFO. It will be behind a kernel config option to not break existing support driving the magnetometer from the kernel. > > Hope to have this cleaned-up and ready soon. OK. Just send this one as a precursor in that series as then the purpose should be obvious. Thanks, Jonathan > > Best regards, > JB > > From: linux-iio-owner@vger.kernel.org on behalf of Jonathan Cameron > > Sent: Monday, August 5, 2019 18:32 > > To: Jean-Baptiste Maneyrol > > Cc: linux-iio@vger.kernel.org > > Subject: Re: [PATCH] iio: imu: inv_mpu6050: add header include protection macro > >   > > >  CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > On Mon, 5 Aug 2019 12:25:43 +0000 > > Jean-Baptiste Maneyrol wrote: > > > > > Signed-off-by: Jean-Baptiste Maneyrol > > No problem with adding this,  but why specifically did you do so? > > > > Thanks, > > > > Jonathan > > > > > --- > > >  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 6 ++++++ > > >  1 file changed, 6 insertions(+) > > > > > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > index db1c6904388b..e64eb978e810 100644 > > > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h > > > @@ -2,6 +2,10 @@ > > >  /* > > >  * Copyright (C) 2012 Invensense, Inc. > > >  */ > > > + > > > +#ifndef INV_MPU_IIO_H_ > > > +#define INV_MPU_IIO_H_ > > > + > > >  #include > > >  #include > > >  #include > > > @@ -342,3 +346,5 @@ void inv_mpu_acpi_delete_mux_client(struct i2c_client *client); > > >  int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, > > >                int (*inv_mpu_bus_setup)(struct iio_dev *), int chip_type); > > >  extern const struct dev_pm_ops inv_mpu_pmops; > > > + > > > +#endif > > >