From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <jonathan.cameron@huawei.com>, <linux-iio@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Cc: Martyn Welch <martyn.welch@collabora.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH] iio:light:noa1305: Fix missing break statement.
Date: Tue, 13 Aug 2019 21:38:51 +0800 [thread overview]
Message-ID: <20190813133851.14345-1-Jonathan.Cameron@huawei.com> (raw)
This got caught by the implicit fall through detection but is
a bug rather than missing marking.
Reported-by: 0-DAY kernel test infrastructure
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
---
drivers/iio/light/noa1305.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
index 7b859ae1044d..5ebfbc52f541 100644
--- a/drivers/iio/light/noa1305.c
+++ b/drivers/iio/light/noa1305.c
@@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
case NOA1305_INTEGR_TIME_400MS:
*val = 100;
*val2 = 77 * 4;
+ break;
case NOA1305_INTEGR_TIME_200MS:
*val = 100;
*val2 = 77 * 2;
--
2.20.1
next reply other threads:[~2019-08-13 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:38 Jonathan Cameron [this message]
2019-08-13 13:58 ` [PATCH] iio:light:noa1305: Fix missing break statement Greg KH
2019-08-13 17:25 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813133851.14345-1-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=martyn.welch@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).