From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5E1C32750 for ; Tue, 13 Aug 2019 13:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0EDB20840 for ; Tue, 13 Aug 2019 13:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565704685; bh=5hY8OZVsklcPrzPyZuR0CGTcNrqsFhS18bZmriS/fD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1g2rKHtW+i2BQAL24w2eQltzg5DZrDDT+HtKmpBcPUtuRRvLX0UAXfUNZVMoPIR8v 3yJIEY6KwPfbYSIFqxPPT1zbnV58MXEyAs3ocaxvwIBHbm4FRry71DnICRHB9dtfZX HJx08fR4vkxifiunK7uFDMpYtGN2KPyvJTTUo/iw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728430AbfHMN6F (ORCPT ); Tue, 13 Aug 2019 09:58:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:35656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728205AbfHMN6F (ORCPT ); Tue, 13 Aug 2019 09:58:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FE62206C2; Tue, 13 Aug 2019 13:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565704684; bh=5hY8OZVsklcPrzPyZuR0CGTcNrqsFhS18bZmriS/fD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y8Khf+8WwAyiOpzydqnUl0JPHB5gMKBIBn5Kn5E8Z0z9bSI/R3Ye0B1KQNufnZRJ+ xKqHMq/KF2ODN0BQfsJoXD179qnt6v/C5NnJaGIuzTVUrsQnY/AKz49IKtGp7LdW2q hsyqbGq2YrpffOcISbd6Wqlgye/kfWchk6rHJ3SM= Date: Tue, 13 Aug 2019 15:58:02 +0200 From: Greg KH To: "Gustavo A. R. Silva" , Jonathan Cameron Cc: linux-iio@vger.kernel.org, Martyn Welch Subject: Re: [PATCH] iio:light:noa1305: Fix missing break statement. Message-ID: <20190813135802.GB27392@kroah.com> References: <20190813133851.14345-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813133851.14345-1-Jonathan.Cameron@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Aug 13, 2019 at 09:38:51PM +0800, Jonathan Cameron wrote: > This got caught by the implicit fall through detection but is > a bug rather than missing marking. > > Reported-by: 0-DAY kernel test infrastructure > Signed-off-by: Jonathan Cameron > Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305") > --- > drivers/iio/light/noa1305.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c > index 7b859ae1044d..5ebfbc52f541 100644 > --- a/drivers/iio/light/noa1305.c > +++ b/drivers/iio/light/noa1305.c > @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2) > case NOA1305_INTEGR_TIME_400MS: > *val = 100; > *val2 = 77 * 4; > + break; > case NOA1305_INTEGR_TIME_200MS: > *val = 100; > *val2 = 77 * 2; > -- > 2.20.1 > Gustavo, your work caught a bug _before_ it hit Linus's tree this time :) I'll go queue this up now, thanks for the fast response Jonathan. greg k-h