From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C553EC32750 for ; Tue, 13 Aug 2019 19:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CF9D2054F for ; Tue, 13 Aug 2019 19:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oeUsGepx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfHMTbb (ORCPT ); Tue, 13 Aug 2019 15:31:31 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37502 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfHMTba (ORCPT ); Tue, 13 Aug 2019 15:31:30 -0400 Received: by mail-qt1-f196.google.com with SMTP id y26so107594471qto.4; Tue, 13 Aug 2019 12:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZrsJ75uAl0CvFW97qeOMuBabIxioxFuZCHkYM94A0LA=; b=oeUsGepxWxGwvAWqyLXN21B4JepvWUV9hHbolgX2xKRyBoUoRrxCEddc4hAtHT7HQ+ AoGnnCk3xWvxMnSmHdAk5aCTAE7fCx7UhHQI3uTM40S6/5E07y/arn0Lek8qRxQOxBuP TV3lGCGcNuGw+zYZGj5NTx1fc7zCiJgDk1xjJ8X/ewyQcNAgQodATlqbCVeq7ynHJQhj 8xGZkD5otdl/CmNVMLERUUQjGYc1NBi62Nlnk9ih6xntQI6cwyGrS8tS0MnI+kSXnv4s yR78QP1gwLm77D+paUklwomMEzbYtajHT3C2V2KTZFQpsvOdzRiy/99dKhisq8+oyIfV 9f3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZrsJ75uAl0CvFW97qeOMuBabIxioxFuZCHkYM94A0LA=; b=iUgW++zOBS1kFXWlr0zC513lf4CZJT9Hiqc2UH9JmgcqQFp3yLkiFwT6zxDZ0UJJ5y 26E2xXZ6WjElWIw3HdcD+pzAj1PrpOIK1MO0N3S0baZhjPYIe9MyTAV7ki0fwscgiVtj x8E3RNhMhyPwtCvS78fHyoBAWsYRSsKDN2P6PIfRLQCZ6wfff7lMLN1Ta6C9TWyvDZzs wBok/D5ux0+HHebBKyNJpFulpvcGT6qNnO8BlQiRQzI9fqFAqIK750NsT4XyFpxJIOZW hHMxupIHJG+pVzDCxm9WnnlKc+jPPKrL1NL1D/q/v7jaCLUVq83wfj0prdmaJCsZrjxn 3VXw== X-Gm-Message-State: APjAAAWSL0TbNUGKOGOq2ES2oyXFAX97oymP+YDfdYJhbkI1HIULiKRN x/QPaLtarQwByTK7fdLF/Mk= X-Google-Smtp-Source: APXvYqyE30ghXoW4lyuazBzGdIN1K2YIYdWEw1TaM6LGrPL7xJwCrZqQ6LKihXqLCTqfIS7vkKFSEA== X-Received: by 2002:ac8:2b47:: with SMTP id 7mr26123152qtv.116.1565724689118; Tue, 13 Aug 2019 12:31:29 -0700 (PDT) Received: from rodrigo-note.semfio.usp.br ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id 145sm2382399qkm.1.2019.08.13.12.31.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 12:31:28 -0700 (PDT) From: Rodrigo Ribeiro To: Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: kernel-usp@googlegroups.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Rodrigo Ribeiro Carvalho Subject: [PATCH v2] staging: iio: accel: adis16240: Improve readability on write_raw function Date: Tue, 13 Aug 2019 16:31:01 -0300 Message-Id: <20190813193101.26867-1-rodrigorsdc@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Replace shift and minus operation by GENMASK macro and remove the local variables used to store intermediate data. Signed-off-by: Rodrigo Ribeiro Carvalho --- v2: - Leave switch statement instead of replace by if statement drivers/staging/iio/accel/adis16240.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c index 62f4b3b1b457..82099db4bf0c 100644 --- a/drivers/staging/iio/accel/adis16240.c +++ b/drivers/staging/iio/accel/adis16240.c @@ -309,15 +309,12 @@ static int adis16240_write_raw(struct iio_dev *indio_dev, long mask) { struct adis *st = iio_priv(indio_dev); - int bits = 10; - s16 val16; u8 addr; switch (mask) { case IIO_CHAN_INFO_CALIBBIAS: - val16 = val & ((1 << bits) - 1); addr = adis16240_addresses[chan->scan_index][0]; - return adis_write_reg_16(st, addr, val16); + return adis_write_reg_16(st, addr, val & GENMASK(9, 0)); } return -EINVAL; } -- 2.20.1