From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F834C32753 for ; Wed, 14 Aug 2019 09:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D146204EC for ; Wed, 14 Aug 2019 09:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbfHNJWU (ORCPT ); Wed, 14 Aug 2019 05:22:20 -0400 Received: from viti.kaiser.cx ([85.214.81.225]:43064 "EHLO viti.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbfHNJWU (ORCPT ); Wed, 14 Aug 2019 05:22:20 -0400 Received: from x4dbd508b.dyn.telefonica.de ([77.189.80.139] helo=martin-debian-1.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hxpU0-0008O2-BN; Wed, 14 Aug 2019 11:22:16 +0200 From: Martin Kaiser To: Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH] iio: max5487: use devres for iio device registration Date: Wed, 14 Aug 2019 11:22:05 +0200 Message-Id: <20190814092205.11031-1-martin@kaiser.cx> X-Mailer: git-send-email 2.11.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Replace iio_device_register with the devres variant and drop the explicit function call to unregister the iio device. Signed-off-by: Martin Kaiser --- drivers/iio/potentiometer/max5487.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/potentiometer/max5487.c b/drivers/iio/potentiometer/max5487.c index 68ff806d4668..a6c92050d397 100644 --- a/drivers/iio/potentiometer/max5487.c +++ b/drivers/iio/potentiometer/max5487.c @@ -110,15 +110,11 @@ static int max5487_spi_probe(struct spi_device *spi) if (ret < 0) return ret; - return iio_device_register(indio_dev); + return devm_iio_device_register(&spi->dev, indio_dev); } static int max5487_spi_remove(struct spi_device *spi) { - struct iio_dev *indio_dev = dev_get_drvdata(&spi->dev); - - iio_device_unregister(indio_dev); - /* save both wiper regs to NV regs */ return max5487_write_cmd(spi, MAX5487_COPY_AB_TO_NV); } -- 2.11.0