* [bug report] iio: imu: Add support for the ADIS16460 IMU
@ 2019-08-15 8:59 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-08-15 8:59 UTC (permalink / raw)
To: alexandru.ardelean; +Cc: linux-iio
Hello Alexandru Ardelean,
The patch db6ed4d23dd1: "iio: imu: Add support for the ADIS16460 IMU"
from Jul 23, 2019, leads to the following static checker warning:
drivers/iio/imu/adis16460.c:158 adis16460_set_freq()
warn: 't' unsigned <= 0
drivers/iio/imu/adis16460.c
152 static int adis16460_set_freq(struct iio_dev *indio_dev, int val, int val2)
153 {
154 struct adis16460 *st = iio_priv(indio_dev);
155 unsigned int t;
^^^^^^^^^^^^^^
156
157 t = val * 1000 + val2 / 1000;
158 if (t <= 0)
^^^^^^
Unsigned is not less than zero.
159 return -EINVAL;
160
161 t = 2048000 / t;
162 if (t > 2048)
163 t = 2048;
164
165 if (t != 0)
166 t--;
167
168 return adis_write_reg_16(&st->adis, ADIS16460_REG_DEC_RATE, t);
169 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-15 8:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 8:59 [bug report] iio: imu: Add support for the ADIS16460 IMU Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).