From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E25C3A589 for ; Sun, 18 Aug 2019 19:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C6F52183E for ; Sun, 18 Aug 2019 19:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfHRTHM (ORCPT ); Sun, 18 Aug 2019 15:07:12 -0400 Received: from saturn.retrosnub.co.uk ([46.235.226.198]:38918 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfHRTHM (ORCPT ); Sun, 18 Aug 2019 15:07:12 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 6B5DC9E7644; Sun, 18 Aug 2019 20:07:09 +0100 (BST) Date: Sun, 18 Aug 2019 20:07:08 +0100 From: Jonathan Cameron To: Rob Herring Cc: Mircea Caprioru , Michael Hennerich , Stefan Popa , Lars-Peter Clausen , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org Subject: Re: [PATCH V3 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192 Message-ID: <20190818200708.659eb4bb@archlinux> In-Reply-To: <20190818194627.4bc9571a@archlinux> References: <20190814073150.4602-1-mircea.caprioru@analog.com> <20190814073150.4602-4-mircea.caprioru@analog.com> <20190818194627.4bc9571a@archlinux> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 18 Aug 2019 19:46:27 +0100 Jonathan Cameron wrote: > On Wed, 14 Aug 2019 20:39:04 -0600 > Rob Herring wrote: > > > On Wed, Aug 14, 2019 at 1:32 AM Mircea Caprioru > > wrote: > > > > > > This patch add device tree binding documentation for AD7192 adc in YAML > > > format. > > > > > > Signed-off-by: Mircea Caprioru > > > --- > > > Changelog V2: > > > - remove description from spi and interrupt properties > > > - changed the name of the device from ad7192 to adc in the example > > > > > > Changelog V3: > > > - added semicolon at the end of the dt example > > > > > > .../bindings/iio/adc/adi,ad7192.yaml | 121 ++++++++++++++++++ > > > 1 file changed, 121 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > > > Reviewed-by: Rob Herring > > For some reason, this patch gave me a git error based on encoding. > I applied it by hand instead and all seemed fine. Not sure why > that happened! > > Applied to the togreg branch of iio.git and pushed out as testing > so the autobuilders can play with it. > > Thanks, > > Jonathan > I spoke a bit soon as the build test was still running. you have const values for the regulators - that doesn't make much sense to my mind and means your example gives warnings... items: - const: dvdd /iio/Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dt.yaml: adc@0: dvdd-supply:0: 'dvdd' was expected I've dropped this and will pick up in v4. thanks, Jonathan