From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 678B8C3A5A5 for ; Tue, 3 Sep 2019 16:33:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3723623400 for ; Tue, 3 Sep 2019 16:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567528385; bh=jCOX+SwGOag7NdIay0mRQzQ2qpqHCUBCiuFIo8hWuzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cI/oOMqzeAJuSc1co20iDFhnLtWKCuIxtthBruVN4FWJYhJ5v2DjMsz1IGcEzr7Nk 7I0ASX/KUlcqqZeuFxAQ/ihA+SKzBAQPCte+YUgTs8rjR0SmVv6z7AuL0zgmfCErm4 8pTYnaIv8gHjtp0XXJppVTd7DuaK8gt7T4z8dTps= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731392AbfICQcF (ORCPT ); Tue, 3 Sep 2019 12:32:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:55370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731390AbfICQcE (ORCPT ); Tue, 3 Sep 2019 12:32:04 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57379238C7; Tue, 3 Sep 2019 16:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567528323; bh=jCOX+SwGOag7NdIay0mRQzQ2qpqHCUBCiuFIo8hWuzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OY8vHw7pQkgKg0IDnzeUWQ/37gMAlMH7oNWT6EU3DOEXDmKUWX36oUYL5f+u19LUD FR4dc9mZtnw4OB2kE/fm/9T8HebnJG/wH1+EDcwkAS9otiNpNVZB4xSFCCvq5D+pFF oi3yPkKWfcHuK/ruIdMgfVUXD1lUUCJKdUkKQRV8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Wolfram Sang , Jonathan Cameron , Sasha Levin , linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 155/167] iio: adc: gyroadc: fix uninitialized return code Date: Tue, 3 Sep 2019 12:25:07 -0400 Message-Id: <20190903162519.7136-155-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190903162519.7136-1-sashal@kernel.org> References: <20190903162519.7136-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Arnd Bergmann [ Upstream commit 90c6260c1905a68fb596844087f2223bd4657fee ] gcc-9 complains about a blatant uninitialized variable use that all earlier compiler versions missed: drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Return -EINVAL instead here and a few lines above it where we accidentally return 0 on failure. Cc: stable@vger.kernel.org Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver") Signed-off-by: Arnd Bergmann Reviewed-by: Wolfram Sang Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/rcar-gyroadc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c index dcb50172186f4..f3a966ab35dcb 100644 --- a/drivers/iio/adc/rcar-gyroadc.c +++ b/drivers/iio/adc/rcar-gyroadc.c @@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) dev_err(dev, "Only %i channels supported with %s, but reg = <%i>.\n", num_channels, child->name, reg); - return ret; + return -EINVAL; } } @@ -400,7 +400,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) dev_err(dev, "Channel %i uses different ADC mode than the rest.\n", reg); - return ret; + return -EINVAL; } /* Channel is valid, grab the regulator. */ -- 2.20.1