From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v6 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt
Date: Mon, 9 Sep 2019 14:05:46 +0200 [thread overview]
Message-ID: <20190909120546.GE2990@localhost.localdomain> (raw)
In-Reply-To: <20190909112846.55280-5-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]
> Report iio motion events to iio subsystem
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v4:
> * Updated bitmask as pr Jonathans comments
>
> Changes since v5:
> * None
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 5 ++
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 70 ++++++++++++++++++++
> 2 files changed, 75 insertions(+)
>
[...]
> static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private)
> {
> return IRQ_WAKE_THREAD;
> @@ -1668,6 +1726,18 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private)
> {
> struct st_lsm6dsx_hw *hw = private;
> int count;
> + int data, err;
> +
> + if (hw->enable_event) {
Maybe I understood the issue between the buffered reading and event generation.
I guess it is a race here between when the device is generating the interrupt
and when you set enable_event. I think there are two solutions:
1- trivial one: always read wakeup_src_reg
2- set hw->enable_event as first instruction in st_lsm6dsx_write_event_config()
and roll back in case of error.
Could you please try that changes and double check if you are still able to
trigger the issue?
Regards,
Lorenzo
> + err = regmap_read(hw->regmap,
> + hw->settings->event_settings.wakeup_src_reg,
> + &data);
> + if (err < 0)
> + return IRQ_NONE;
> +
> + if (data & hw->settings->event_settings.wakeup_src_status_mask)
> + st_lsm6dsx_report_motion_event(hw, data);
> + }
>
> mutex_lock(&hw->fifo_lock);
> count = hw->settings->fifo_ops.read_fifo(hw);
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-09-09 12:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 11:28 [PATCH v6 1/6] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-09 11:28 ` [PATCH v6 2/6] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-09 11:28 ` [PATCH v6 3/6] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-09 11:28 ` [PATCH v6 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-09 11:28 ` [PATCH v6 5/6] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-09 11:51 ` Sean Nyekjaer
2019-09-15 12:20 ` Jonathan Cameron
2019-09-15 12:24 ` Sean Nyekjaer
2019-09-15 13:06 ` Jonathan Cameron
2019-09-09 12:05 ` Lorenzo Bianconi [this message]
2019-09-09 12:41 ` Sean Nyekjaer
2019-09-10 7:12 ` Lorenzo Bianconi
2019-09-10 7:17 ` Sean Nyekjaer
2019-09-10 7:26 ` Lorenzo Bianconi
2019-09-10 12:27 ` Lorenzo Bianconi
2019-09-11 12:41 ` Sean Nyekjaer
2019-09-11 12:59 ` Lorenzo Bianconi
2019-09-09 11:28 ` [PATCH v6 6/6] iio: imu: st_lsm6dsx: prohibit the use of events and buffered reads simultaneously Sean Nyekjaer
2019-09-09 11:55 ` Lorenzo Bianconi
2019-09-09 11:59 ` Sean Nyekjaer
2019-09-09 12:01 ` Sean Nyekjaer
2019-09-09 12:45 ` [PATCH v6.1 " Sean Nyekjaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909120546.GE2990@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).